Back off when writing to Dynamo and S3 #2723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekimekim
approved these changes
Jul 18, 2017
app/multitenant/aws_collector.go
Outdated
| time.Sleep(backoff) | ||
| err = f() | ||
| retries += 1 | ||
| backoff *= 2 |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
rade
suggested changes
Jul 18, 2017
app/multitenant/aws_collector.go
Outdated
| ReturnConsumedCapacity: aws.String(dynamodb.ReturnConsumedCapacityTotal), | ||
| ReturnConsumedCapacity: aws.String(dynamodb.ReturnConsumedCapacityTotal), | ||
| }) | ||
| return err |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
app/multitenant/aws_collector.go
Outdated
| var reportSize int | ||
| err = withBackoff(func() error { | ||
| var err error | ||
| reportSize, err = c.s3.StoreReportBytes(ctx, reportKey, buf) |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
added 2 commits
July 20, 2017 10:05
rade
approved these changes
Jul 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2345
I am intentionally not backing off when writing to Memcached nor NATS. The first one is an optimization and the second one is just used for shortcut reports (not essential).
I tried to use https://github.com/weaveworks/common/blob/master/backoff/backoff.go but it's not suitable for this usecase (it doesn't forward errors and doesn't accept retry limits).