Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix yarn pack ignoring directory cli flag #2694

Merged
merged 1 commit into from
Jul 7, 2017
Merged

Fix yarn pack ignoring directory cli flag #2694

merged 1 commit into from
Jul 7, 2017

Conversation

rndstr
Copy link
Contributor

@rndstr rndstr commented Jul 7, 2017

No description provided.

@rndstr rndstr requested a review from fbarl July 7, 2017 11:01
@rade
Copy link
Member

rade commented Jul 7, 2017

So what's currently broken that this fixes?

@rade
Copy link
Member

rade commented Jul 7, 2017

So what's currently broken that this fixes?

Ignore me; just figured it out.

fbarl
fbarl approved these changes Jul 7, 2017
View reviewed changes
Copy link
Contributor

@fbarl fbarl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's give it a try.

@rndstr rndstr merged commit 7f078a8 into master Jul 7, 2017
@rndstr rndstr deleted the yarn-pack-is-not-npm-pack branch July 7, 2017 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbarl fbarl fbarl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rndstr @rade @fbarl