Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

es6ify server.js and include in eslint #2560

Merged
merged 2 commits into from
Jun 8, 2017
Merged

Conversation

rndstr
Copy link
Contributor

@rndstr rndstr commented Jun 3, 2017

also updated documentation for minimum Node.js version required.

Edit: also explicitly set hosts to localhost for expressjs servers to make it easier to click on the logged links in case of ipv6 default address.

rndstr added 2 commits June 3, 2017 13:22
also updated documentation for minimum Node.js version required.
Otherwise logged http links are invalid if default address is ipv6.
@2opremio 2opremio requested a review from fbarl June 4, 2017 09:39
Copy link
Contributor

@fbarl fbarl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

p.s. Sorry for taking so long..

@rndstr rndstr merged commit 5ef7bd1 into master Jun 8, 2017
@rndstr rndstr deleted the client-serverjs-linting branch June 8, 2017 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants