Use Kubernetes node name to filter pods if possible #2556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To be effective, this requires an associated change in launch-generator for the next release of Scope (CC @errordeveloper ) |
2opremio
reviewed
Jun 2, 2017
| reporter := &Reporter{ | ||
| client: client, | ||
| pipes: pipes, | ||
| probeID: probeID, | ||
| probe: probe, | ||
| hostID: hostID, | ||
| handlerRegistry: handlerRegistry, | ||
| nodeName: nodeName, |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
@bboreham Can you please fix the tests? |
2opremio
approved these changes
Jun 19, 2017
bboreham
force-pushed
the
local-pods-via-node-name
branch
from
5e8c0a0 to
88ca981
Compare
rade
reviewed
Jul 13, 2017
| kubeletPort uint | ||
| } | ||
|
|
||
| // NewReporter makes a new Reporter | ||
| func NewReporter(client Client, pipes controls.PipeClient, probeID string, hostID string, probe *probe.Probe, handlerRegistry *controls.HandlerRegistry, kubeletPort uint) *Reporter { | ||
| func NewReporter(client Client, pipes controls.PipeClient, probeID string, hostID string, probe *probe.Probe, handlerRegistry *controls.HandlerRegistry, nodeName string, kubeletPort uint) *Reporter { |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can get the node name via the downward api, if the Scope probe is run as a pod. This needs to be done in the yaml.