Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use prop-types library to silence PropTypes deprecation warning #2498

Merged
merged 2 commits into from
May 5, 2017
Merged

Use prop-types library to silence PropTypes deprecation warning #2498

merged 2 commits into from
May 5, 2017

Conversation

fbarl
Copy link
Contributor

@fbarl fbarl commented May 4, 2017 •
edited
Loading

Will fix #2496 once weaveworks/ui-components#27 is merged and weaveworks-ui-components version is updated.

Fixes #2496.

@fbarl fbarl self-assigned this May 4, 2017
@fbarl fbarl changed the title [WIP] Use prop-types library to fix PropTypes deprecation warning Use prop-types library to silence PropTypes deprecation warning May 5, 2017
@fbarl fbarl requested a review from jpellizzari May 5, 2017 10:05
@fbarl fbarl merged commit 10b276c into master May 5, 2017
@fbarl fbarl deleted the fix-prop-types branch June 16, 2017 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpellizzari jpellizzari jpellizzari approved these changes

Assignees

@fbarl fbarl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move away from React.PropTypes
2 participants
@fbarl @jpellizzari