Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eliminate excessive calls to mtime.Now() #2486

Merged
merged 2 commits into from
Apr 29, 2017
Merged

eliminate excessive calls to mtime.Now() #2486

merged 2 commits into from
Apr 29, 2017

Conversation

rade
Copy link
Member

@rade rade commented Apr 28, 2017

No description provided.

rade added 2 commits April 28, 2017 23:43
@rade
make Node.WithTableTruncationInformation private
911f456 
It is not used elsewhere and is rather specialised.
@rade
eliminate excessive calls to mtime.Now()
17b88b4 
This isn't going to noticeably improve performance, but enables future
optimisations, e.g. more compact representations of LatestMaps where
many/all entries share the same timestamp.
@rade rade requested a review from ekimekim April 28, 2017 22:59
ekimekim
ekimekim approved these changes Apr 29, 2017
View reviewed changes
Copy link
Contributor

@ekimekim ekimekim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Though shouldn't the performance gain be negligible since clock_gettime() doesn't do a full system call on most platforms?

@rade
Copy link
Member Author

rade commented Apr 29, 2017 •
edited
Loading

Shouldn't the performance gain be negligible

I said that much in the commit message: "This isn't going to noticeably improve performance"

@rade rade merged commit b7eb53a into master Apr 29, 2017
@rade rade deleted the less-now branch July 5, 2017 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekimekim ekimekim ekimekim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rade @ekimekim