proc walker: optimize open file counter #2456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alban
force-pushed
the
alban/open-files-count
branch
2 times, most recently
from
8d82195 to
3139053
Compare
1 task
alban
force-pushed
the
alban/open-files-count
branch
from
3139053 to
d1f85e8
Compare
Golang's ReadDirNames is expensive and better avoided when we don't care about the names.
alban
force-pushed
the
alban/open-files-count
branch
from
d1f85e8 to
640b240
Compare
alban
changed the title
|
@2opremio I updated the vendoring, but not to HEAD, as described on weaveworks/common#34 (comment) PTAL |
2opremio
approved these changes
May 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Golang's ReadDirNames is expensive and better avoided when we don't care
about the names.
See discussion in #1011
I tested the performances by looking at the Scope cpu usage with
top -d 10:TODO: