Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch resource view topologies on first topologies load #2390

Merged
merged 1 commit into from
Mar 24, 2017

Conversation

fbarl
Copy link
Contributor

@fbarl fbarl commented Mar 24, 2017

No calls for the relevant topologies in the resource view were being made because getResourceViewNodesSnapshot would be called before we'd get the response from api/topology with all the topologies' urls.

Timeout of 1200ms made it work locally, but wasn't a proper solution for the dev. Hopefully this fixes #2391.

@fbarl fbarl requested a review from jpellizzari March 24, 2017 17:50
@fbarl fbarl changed the title HOTFIX - Fetch resource view topologies on first topologies load Fetch resource view topologies on first topologies load Mar 24, 2017
Copy link
Contributor

@jpellizzari jpellizzari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fbarl fbarl merged commit 32988c0 into master Mar 24, 2017
@fbarl fbarl deleted the fix-resource-view-not-loading-topologies branch March 31, 2017 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resource view not rendering anything on dev
2 participants