When k8s present, allow filtering of containers by namespace (take 2) #2362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in-container-view"" This reverts commit d55c528.
…ing code This was causing a large number of repeated appending of the same option group
rade
reviewed
Mar 20, 2017
app/api_topologies.go
Outdated
| topologies[i] = updateTopologyFilters(t, []APITopologyOptionGroup{ | ||
| kubernetesFilters(ns...), unmanagedFilter, | ||
| }) | ||
| if len(ns) > 0 { // We only want to apply k8s filters when we have k8s-related nodes |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
2opremio
approved these changes
Mar 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-applies #2285 (reverted in #2348)
and fixes the bug(s) that prompted the revert, which turned out to be a matter of accidentially mutating
objects in a variety of ways, some of which were introduced by #2285 but
others that weren't, but were exposed as a problem due to changing the operation from a set to an append.
Fixes #1504