Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed url state copy/paste bug #2340

Merged
merged 1 commit into from
Mar 16, 2017
Merged

Fixed url state copy/paste bug #2340

merged 1 commit into from
Mar 16, 2017

Conversation

jpellizzari
Copy link
Contributor

@jpellizzari jpellizzari commented Mar 16, 2017

Fix for #2337

Reverted changes made here: d775020#diff-7dc7875cc44ad2eec50c55c6932e6ec2

@rade
Copy link
Member

rade commented Mar 16, 2017

What was the motivation behind the original change? Or was it accidental?

@jpellizzari
Copy link
Contributor Author

The motivation behind the original change was to prevent scope re-routing when switching to flux or prom within Weave Cloud. The page module conflicts with the react-router module, since they are both trying to do the same thing.

Since scope has been rolled back to an iframe, this change should restore the behavior until I can figure out how to work around it. It's also worth noting that the page module is no longer maintained, and is also causing problems with deep linking.

@jpellizzari jpellizzari merged commit 3e21445 into master Mar 16, 2017
@jpellizzari jpellizzari deleted the 2237-scope-urls branch March 21, 2017 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants