Improve error reporting when invoking weave script #2335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekimekim
approved these changes
Mar 17, 2017
There was a problem hiding this comment.
This adds (I think? Unsure without looking under the hood whether previously stderr was a pipe or not) a deadlock condition where stderr fills up, but we aren't reading from it because we're waiting for stdout to EOF, but stdout isn't EOFing because the program is blocking trying to write to stderr.
It's non-trivial to fix and very unlikely to ever be a real issue, so I'm happy to ignore it.
LGTM
* The Stderr pipe should be read before waiting * The Stderr pipe should not be used with Run/Output. See https://golang.org/pkg/os/exec/#Cmd.StderrPipe: Wait will close the pipe after seeing the command exit, so most callers need not close the pipe themselves; however, an implication is that it is incorrect to call Wait before all reads from the pipe have completed. For the same reason, it is incorrect to use Run when using StderrPipe.
|
@ekimekim I fixed a couple of problems, please take another look |
ekimekim
approved these changes
Mar 17, 2017
|
modulo tests passing, ofc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2191