Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a JS bug where certain query strings would contain a && instead of & #1953

Closed
wants to merge 1 commit into from

Conversation

ekimekim
Copy link
Contributor

This was causing 400s when talking to overly-strict services

This was causing 400s when talking to overly-strict services
@davkal
Copy link
Contributor

davkal commented Oct 27, 2016

I cannot reproduce the issue, so I cannot verify if this in fact fixes the 400.

I've tried /api/topology/services?t=5s&&&&namespace=default&pseudo=hide on our prod cloud instance, and got a normal 200.

davkal added a commit that referenced this pull request Oct 27, 2016
@davkal
Copy link
Contributor

davkal commented Oct 27, 2016

Ah, I see what happened, this line messed it up:
${wsUrl}${topologyUrl}/ws?t=${updateFrequency}&${optionsQuery}
because it prepends a & to the query string that has & as prefix.

Closing this, in favor of #1956, which uses the immutable object function and adds a test.

@davkal davkal closed this Oct 27, 2016
@rade rade deleted the mike/fix-js-query-string branch July 5, 2017 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants