Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve installation documentation #1838

Merged
merged 7 commits into from
Oct 6, 2016
Merged

Improve installation documentation #1838

merged 7 commits into from
Oct 6, 2016

Conversation

abuehrle
Copy link
Contributor

Edits to install page.

@abuehrle abuehrle mentioned this pull request Sep 1, 2016
Closed
@2opremio
Copy link
Contributor

@abuehrle Are you still intending to merge this? As you probably noticed, this PR carries some unintended code changes. Need some help getting those removed from the PR?

@abuehrle
Copy link
Contributor Author

@fons that would be great.

@2opremio
Copy link
Contributor

2opremio commented Sep 12, 2016 •
edited
Loading

@abuehrle PTAL. I've done my best but I am not sure I've brought it to the state you wanted it to be (there were duplicated commits, and a merge named extra space which was empty). I've created and pushed branch faddats-doc-changes-backup with the original content in case you want to revert the changes or see its prior state.

@lukemarsden
Copy link
Contributor

lukemarsden commented Sep 12, 2016 •
edited
Loading

Changes LGTM, modulo one review comment. CI is sad but it looks transient, re-running.

lukemarsden
lukemarsden reviewed Sep 12, 2016
View reviewed changes
site/installing.md
**3. And on the second node:**

scope launch 192.168.100.17 192.168.100.20 192.168.100.21
scope launch 192.168.100.17 192.168.100.18 192.168.100.21

This comment was marked as abuse.

Sign in to view

@2opremio
Copy link
Contributor

@abuehrle ping

@abuehrle
changed wording for peering cluster
f270c97 
also clarified security note
@abuehrle
Copy link
Contributor Author

abuehrle commented Sep 27, 2016 •
edited
Loading

@lukemarsden I changed the wording slightly, but I'm still not sure if this is clear. Do we peer each node to all of the other nodes. The way it's listed, it sounds like one takes a node and then peers them all at once to all the others. Is that what's meant?

@2opremio
Copy link
Contributor

2opremio commented Oct 6, 2016

@lukemarsden Are you OK with the changes? This PR has been open for a month now.

@lukemarsden
Copy link
Contributor

LGTM, sorry this took so long.

@lukemarsden lukemarsden closed this Oct 6, 2016
@lukemarsden lukemarsden reopened this Oct 6, 2016
@lukemarsden lukemarsden merged commit a2f6090 into master Oct 6, 2016
@2opremio 2opremio changed the title {WIP} Faddats doc changes Improve installation documentation Nov 4, 2016
@abuehrle abuehrle deleted the faddats-doc-changes branch November 10, 2016 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lukemarsden lukemarsden

@abuehrle abuehrle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abuehrle @2opremio @lukemarsden