Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alessandro/fix scope stop osx #1811

Conversation

alepuccetti
Copy link

Before this patch, scope stop was not stopping scope-app

@rade
Copy link
Member

rade commented Aug 17, 2016

This hasn't been re-based properly.

@alepuccetti alepuccetti force-pushed the alessandro/fix-scope-stop-osx branch from df1768f to 0e551bb Compare August 17, 2016 11:17
@alepuccetti
Copy link
Author

@rade sorry, my bad. I rebased it on release-0.17

@2opremio
Copy link
Contributor

@alepuccetti It still carries a lot of other changes. Would you mind resetting and cherry-picking just the fix?

Before this patch, `scope stop` was not stopping scope-app
@alepuccetti alepuccetti force-pushed the alessandro/fix-scope-stop-osx branch from 0e551bb to 5b67adc Compare August 17, 2016 12:10
@alepuccetti
Copy link
Author

@2opremio I did not noticed that I was working on a different branch. Should we merge it also on master?

@2opremio
Copy link
Contributor

@alepuccetti I will merge it to master from release-0.17 later on.

@alepuccetti
Copy link
Author

Got it

On Wed, Aug 17, 2016 at 2:12 PM, Alfonso Acosta [email protected]
wrote:

@alepuccetti https://github.com/alepuccetti I will merge it to master
from release-0.17 later on.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1811 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGRc77PXrKuiurOkXsNbA4U293tJYJWrks5qgvrHgaJpZM4JmVoi
.

Alessandro Puccetti

@2opremio
Copy link
Contributor

@alepuccetti Thanks!

@2opremio
Copy link
Contributor

LGTM

@2opremio 2opremio merged commit 250baa2 into weaveworks:release-0.17 Aug 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants