reduce horizontal gap between nodes in topology views

[rade]

Fixes #1688

[rade]

I've tried this on a few topologies, and did searches on them. See, e.g. #1688 (comment). All seems to look fine.

btw, I don't pretend to know what I am doing here. And the fact that I had to adjust labelWidth to prevent overlapping makes me uneasy - I would have expected that to be adjusted automatically with the node separation factor.

[davkal]

It all comes down to the search results being displayed. Sadly, browser support for controlling their layout (foreignObject in SVG) is limited. So you end up with blocks that are wider than they need to be, and assume full width. At that point they are too close together with the neighbour nodes, see lower row here:

For the row separation, the more-matches text is blocked:

Here is the report I'm using: https://gist.github.com/davkal/b02d9e6c90b73fd39e7d9fbaec11815e

[rade]

At that point they are too close together with the neighbour nodes

I had put a screen shot just like that in #1688. I don't see it as a problem. Yes, more separation would be better, but increasing horizontal node space to do that is worse.

For the row separation, the more-matches text is blocked:

That's about vertical spacing, surely. How does that have anything to do with this change?

[rade]

That's about vertical spacing, surely. How does that have anything to do with this change?

And the answer is: nothing. I get the same (and more) overlap on our dev admin scope running 'master'.

[davkal]

You're right. I thought rank separation was changed here too, but it wasnt.
The node separation LGTM.

[foot]

This LGTM, works nicely on the wide layouts.