Refactor caching layers in dynamo collector #1616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than have getReports be responsible for determining keys, instead call getReportKeys directly and then pass keys to getReports
| @@ -102,18 +91,17 @@ type DynamoDBCollector interface { | |||
|
|
|||
| // ReportStore is a thing that we can get reports from. | |||
| type ReportStore interface { | |||
| FetchReports([]string) ([]report.Report, []string, error) | |||
| FetchReports([]string) (map[string]report.Report, []string, error) | |||
| } | |||
|
|
|||
| type dynamoDBCollector struct { | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
jml
force-pushed
the
debug-instrument-memcache
branch
from
a87dafd to
baacaa8
Compare
|
PTAL. |
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to better understand what was going on, so I refactored it.
Highlights:
dynamo_collectorinto a new file, and given same interface asMemcacheClientNewDynamoDBCollectornow takes both a memcache client and an s3 client, rather than being responsible for constructing bothFetchReportsreturns a map of fetched reports, making it easier to write back to the in-process cacheLowlights:
prog/app.goThis change is