Asset fingerprinting #1354
Merged
Asset fingerprinting #1354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* adds `?hash` to JS and CSS bundle URLs against caching in production * uses `html-webpack-plugin` to generate html dynamically * html based on template in `app/html/index.html` * per-app html files no longer needed * `build/` dir is now completely deleteable, and fully gitignored * top-level `make` now requires `client/app` to pick up on html and style changes * cleaned up `server.js` code for production bundle testing * added readme entry about testing production bundles
|
contrast mode on a production build doesn't appear to be working, but I can't immediately spot why... |
|
terminal is working fine. |
* fixes contrast mode
|
Awesommee! Works really well LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
?hashto JS and CSS bundle URLs against caching in productionhtml-webpack-pluginto generate html dynamicallyapp/html/index.htmlbuild/dir is now completely deleteable, and fully gitignoredmakenow requiresclient/appto pick up on html andstyle changes
server.jscode for production bundle testing