Make scope automagically connect to other scope instances when running on WeaveDNS #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if len(flag.Args()) != 0 { | ||
| flag.Usage() | ||
| os.Exit(1) | ||
| probes = flag.Args() | ||
| } else { | ||
| probes = defaultProbes |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
added 3 commits
May 12, 2015 10:58
…tempt to gather reports from them.
|
If there's nothing else outstanding, LGTM. |
tomwilkie
added a commit
that referenced
this pull request
May 12, 2015
Make scope automagically connect to other scope instances when running on WeaveDNS
tomwilkie
added a commit
that referenced
this pull request
Jan 13, 2016
2opremio
pushed a commit
that referenced
this pull request
Aug 26, 2016
More gce scripts from weave into tools.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... although it doesn't quite work, as weave dns doesn't return multiple entries yet.
I wasn't sure about removing the first parameter from NewCollector as its used in a bunch of places. I can undo that if you like.