Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update vendored copy of k8s.io/client-go #3284

Closed
dholbach opened this issue Jul 26, 2018 · 1 comment · Fixed by #3329
Closed

Please update vendored copy of k8s.io/client-go #3284

dholbach opened this issue Jul 26, 2018 · 1 comment · Fixed by #3329
Assignees

Comments

@dholbach
Copy link
Contributor

Our current copy of k8s.io/client-go uses juju/ratelimit which is LGPL3. Upstream moved away from this in kubernetes/client-go@acc5249 - it'd be good if we followed this change as well.

@dholbach
Copy link
Contributor Author

This was fixed in Weave Net in weaveworks/weave#3366 - they moved to v8.0.0.

satyamz added a commit to satyamz/scope that referenced this issue Aug 24, 2018
This will
Add:
	- golang.org/x/time
upgrade:
        - k8s.io/client-go v8.0.0
	- k8s.io/api version to kubernetes-1.11.0
	- k8s.io/apimachinery version to kubernetes-1.11.0
	- github.com/json-iterator/go version to latest because `https://github.com/kubernetes/kubernetes/issues/64612`
delete:
	- vendor/github.com/juju/ratelimit because k8s-client-go is shifted to golang.org/x/time
	  Please refer: kubernetes/client-go@acc5249

```
gvt delete k8s.io/client-go
gvt delete k8s.io/api
gvt delete k8s.io/apimachinery
gvt delete github.com/json-iterator/go
gvt delete github.com/juju/ratelimit

gvt fetch --no-recurse -tag v8.0.0 k8s.io/client-go
gvt fetch --no-recurse -tag kubernetes-1.11.0 k8s.io/api
gvt fetch --no-recurse -tag kubernetes-1.11.0 k8s.io/apimachinery
gvt fetch github.com/json-iterator/go
gvt fetch golang.org/x/time
```

fixes: weaveworks#3284

Signed-off-by: Satyam Zode <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants