Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grouping behaviour is hard to discover and understand #156

Closed
tomwilkie opened this issue Jun 2, 2015 · 6 comments
Closed

Grouping behaviour is hard to discover and understand #156

tomwilkie opened this issue Jun 2, 2015 · 6 comments
Assignees
Milestone

Comments

@tomwilkie
Copy link
Contributor

This is (my paraphrasing of) feedback from @rade, @squaremo and @awh.

Comments generally include "thats really cool" but "I didn't know to click that small button to make that happen" and "it took a minute for me to figure out what it was doing".

@rade
Copy link
Member

rade commented Jun 2, 2015

Actually, without you explaining what it was doing I would never have figured it out.

@davkal
Copy link
Contributor

davkal commented Jun 3, 2015

Should we just concede defeat and bring the labels back?

@peterbourgon peterbourgon added this to the earlyjune milestone Jun 3, 2015
@peterbourgon
Copy link
Contributor

Applications   Containers    Hosts  
by name        by image          

@davkal davkal self-assigned this Jun 11, 2015
@davkal
Copy link
Contributor

davkal commented Jun 12, 2015

Current topos collection object is:

{
    "name": "Applications",
    "url": "/api/topology/applications",
    "grouped_url": "/api/topology/applications-grouped",
    "stats": {
      "node_count": 12,
      "nonpseudo_node_count": 10,
      "edge_count": 13
    }
  }

I propose to nest sub-topologies:

{
    "name": "Applications",
    "url": "/api/topology/applications",
    "stats": {
      "node_count": 12,
      "nonpseudo_node_count": 10,
      "edge_count": 13
    },
    "sub_topologies": [
       {
           "name": "by name",
           "url": "/api/topology/applications-by-name"
       }
   ]
}

@davkal
Copy link
Contributor

davkal commented Jun 12, 2015

FYI, the UI logic uses the last part of the url as the topology ID, e.g. id(/api/topology/applications-by-name) -> applications-by-name so it would be helpful if we can keep this prefix structure.

@davkal
Copy link
Contributor

davkal commented Jun 15, 2015

Fixed via #222

@davkal davkal closed this as completed Jun 15, 2015
bboreham added a commit that referenced this issue Oct 1, 2019
d6cc704a2 Fix comment
7139116ae Revert "Push comments to the left so they don't appear in scripts"
e47e58f7b Push comments to the left so they don't appear in scripts
3945fcec8 Remove nonexistent env var GIT_TAG
cd6299284 Merge pull request #156 from weaveworks/drop-quay
af0eb5119 Merge pull request #157 from weaveworks/fix-image-tag-prefix-length
0b9aee4f2 Fix image-tag object name prefix length to 8 chars.
813c28fe7 Move from CircleCI 1.0 to 2.0
425cf4ef1 Move from quay.io to Dockerhub
87ccf4fd1 Merge pull request #155 from weaveworks/go-1-12
c31bc2865 Update lint script to work with Go 1.12
ed8e380d7 Update to Go 1.12.1

git-subtree-dir: tools
git-subtree-split: d6cc704a2892e8d85aa8fa4d201c1a404f02dfa4
bboreham added a commit that referenced this issue Oct 1, 2019
b1c21a068 Merge pull request #158 from weaveworks/go-1-13
d5c7dd0cd Run shell-lint during CI, and fix warnings
6db1abd14 Update to Go 1.13.1
d6cc704a2 Fix comment
7139116ae Revert "Push comments to the left so they don't appear in scripts"
e47e58f7b Push comments to the left so they don't appear in scripts
3945fcec8 Remove nonexistent env var GIT_TAG
cd6299284 Merge pull request #156 from weaveworks/drop-quay
af0eb5119 Merge pull request #157 from weaveworks/fix-image-tag-prefix-length
0b9aee4f2 Fix image-tag object name prefix length to 8 chars.
813c28fe7 Move from CircleCI 1.0 to 2.0
425cf4ef1 Move from quay.io to Dockerhub
87ccf4fd1 Merge pull request #155 from weaveworks/go-1-12
c31bc2865 Update lint script to work with Go 1.12
ed8e380d7 Update to Go 1.12.1

git-subtree-dir: tools
git-subtree-split: b1c21a068eae58be882dce4b8d74abb944dce11f
bboreham added a commit that referenced this issue Oct 2, 2019
f041a74ff Undo some quoting that broke the test script (#160)
b1c21a068 Merge pull request #158 from weaveworks/go-1-13
d5c7dd0cd Run shell-lint during CI, and fix warnings
6db1abd14 Update to Go 1.13.1
d6cc704a2 Fix comment
7139116ae Revert "Push comments to the left so they don't appear in scripts"
e47e58f7b Push comments to the left so they don't appear in scripts
3945fcec8 Remove nonexistent env var GIT_TAG
cd6299284 Merge pull request #156 from weaveworks/drop-quay
af0eb5119 Merge pull request #157 from weaveworks/fix-image-tag-prefix-length
0b9aee4f2 Fix image-tag object name prefix length to 8 chars.
813c28fe7 Move from CircleCI 1.0 to 2.0
425cf4ef1 Move from quay.io to Dockerhub
87ccf4fd1 Merge pull request #155 from weaveworks/go-1-12
c31bc2865 Update lint script to work with Go 1.12
ed8e380d7 Update to Go 1.12.1

git-subtree-dir: tools
git-subtree-split: f041a74ffbf273b627d6c960f17357108d0dbd1c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants