Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filters should be associated with views rather than sub-views #1221

Closed
rade opened this issue Apr 4, 2016 · 5 comments
Closed

filters should be associated with views rather than sub-views #1221

rade opened this issue Apr 4, 2016 · 5 comments
Assignees
Labels
component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer
Milestone

Comments

@rade
Copy link
Member

rade commented Apr 4, 2016

I was seeing too many / too few containers when switching between the three Container sub-views ("Container", "By DNS" and "By Image")... until I realised that my selection for "show system/application/both" and "show stopped/running/both" was being apparently being reset when switching sub-views... until I realised that it was in fact saved/restored per sub-view.

I suspect I am not the only user that finds this counter-intuitive. When I tell scope, say, to "show stopped containers", I expect it to apply that selection across all container views.

@rade rade added the component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer label Apr 4, 2016
@davkal
Copy link
Contributor

davkal commented Apr 6, 2016

Let's hear some opinions. For me the current behaviour is normal. But I, too, found myself clicking the same options across sub topologies. So maybe that should change.

@peterbourgon
Copy link
Contributor

Do we expect metrics-on-canvas selectors to persist across views? Given the metrics are different across views, I think the answer has to be "no". Since the UX for metrics-on-canvas widgets is roughly identical to the filters (same place on screen, same interaction model) I think they need to have the same behavior. So I'm with David, the current behavior is less surprising than the proposed alternative.

@davkal
Copy link
Contributor

davkal commented Apr 6, 2016

Do we expect metrics-on-canvas selectors to persist across views?

There is a notion of a metric type. If a metric of similar type is found in the new topo, it's being applied.

@rade
Copy link
Member Author

rade commented Apr 6, 2016

Do we expect metrics-on-canvas selectors to persist across views?

Across sub-views, yes.

Given the metrics are different across views

They are the same across sub-views.

Since the UX for metrics-on-canvas widgets is roughly identical to the filters

That may not be true, despite...

(same place on screen, same interaction model)

@peterbourgon
Copy link
Contributor

There is a notion of a metric type. If a metric of similar type is found in the new topo, it's being applied.

Interesting. OK. I'm for consistency, so if this is happening with MoC, then it should happen with the filters, too.

davkal added a commit that referenced this issue Apr 6, 2016
Subtopologies inherit the applied options if the keys are the same.
The labels are still determined by the topology itself.

Fixes #1221
@tomwilkie tomwilkie added this to the 0.14.0 milestone Apr 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer
Projects
None yet
Development

No branches or pull requests

4 participants