Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weaveworks logo in downloaded graph SVG is yuge. #1071

Closed
pidster opened this issue Mar 1, 2016 · 3 comments
Closed

Weaveworks logo in downloaded graph SVG is yuge. #1071

pidster opened this issue Mar 1, 2016 · 3 comments
Labels
bug Broken end user or developer functionality; not working as the developers intended it component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer

Comments

@pidster
Copy link
Contributor

pidster commented Mar 1, 2016

The logo is excessively large, it should be small enough that it is a discrete addition to the image.
@pidster pidster added component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer bug Broken end user or developer functionality; not working as the developers intended it labels Mar 1, 2016
@pidster
Copy link
Contributor Author

pidster commented Mar 1, 2016

Further info & correction. This feature works as expected in Chrome, Firefox.

In Safari, when the button is clicked the browser opens a URL similar to: "blob:http://192.168.99.100:4040/a57d0b50-82a5-409d-aa79-01f0a7d5d727"
(note the "blob:" prefix)

An example of the result:

safari-is-weird

@davkal
Copy link
Contributor

davkal commented Mar 1, 2016

The logo is weavescope. Should we mention weaveworks too, @pidster ?

davkal added a commit that referenced this issue Mar 1, 2016
@davkal
Fix embedded logo size
833b78c 
* CSS transform is ignored in Safari, using SVG transform instead

Fixes #1071
@davkal davkal mentioned this issue Mar 1, 2016
Merged
@pidster
Copy link
Contributor Author

pidster commented Mar 7, 2016

Scope is fine for now, for the record.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Broken end user or developer functionality; not working as the developers intended it component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pidster @davkal