Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All pseudo nodes are grouped together in the "grouped" view #105

Closed
tomwilkie opened this issue May 26, 2015 · 2 comments · Fixed by #116
Closed

All pseudo nodes are grouped together in the "grouped" view #105

tomwilkie opened this issue May 26, 2015 · 2 comments · Fixed by #116
Assignees
@tomwilkie

Comments

@tomwilkie
Copy link
Contributor

This seems undesirable, implying relationships between unrelated services.

Whats more, they don't have a label in the UI.

Options to fix this include:
@tomwilkie tomwilkie self-assigned this May 26, 2015
@peterbourgon
Copy link
Contributor

implying relationships between unrelated services.

The relationship is that they don't share a defined grouping characteristic. Exactly the same as the Internet node — i.e. a collection of nodes that we don't know much about beyond mere existence.

That said, happy to use the same grouping logic as #99, or simply not show them, as long as we document the decision in the code.

@tomwilkie
Copy link
Contributor Author

I'll take a stab at apply the logic from #99 to this, and see what happens.

@tomwilkie tomwilkie mentioned this issue May 27, 2015
Merged
bboreham added a commit that referenced this issue Jul 13, 2017
@bboreham
Squashed 'tools/' changes from 0d6d4da..74dc626
1eeb4d0 
74dc626 Merge pull request #108 from weaveworks/disable-apt-daily
b4f1d91 Merge pull request #107 from weaveworks/docker-17-update
7436aa1 Override apt daily job to not run immediately on boot
7980f15 Merge pull request #106 from weaveworks/document-docker-install-role
f741e53 Bump to Docker 17.06 from CE repo
61796a1 Update Docker CE Debian repo details
0d86f5e Allow for Docker package to be named docker-ce
065c68d Document selection of Docker installation role.
3809053 Just --porcelain; it defaults to v1
11400ea Merge pull request #105 from weaveworks/remove-weaveplugin-remnants
b8b4d64 remove weaveplugin remnants
35099c9 Merge pull request #104 from weaveworks/pull-docker-py
cdd48fc Pull docker-py to speed tests/builds up.
e1c6c24 Merge pull request #103 from weaveworks/test-build-tags
d5d71e0 Add -tags option so callers can pass in build tags
8949b2b Merge pull request #98 from weaveworks/git-status-tag
ac30687 Merge pull request #100 from weaveworks/python_linting
4b125b5 Pin yapf & flake8 versions
7efb485 Lint python linting function
444755b Swap diff direction to reflect changes required
c5b2434 Install flake8 & yapf
5600eac Lint python in build-tools repo
0b02ca9 Add python linting
c011c0d Merge pull request #79 from kinvolk/schu/python-shebang
6577d07 Merge pull request #99 from weaveworks/shfmt-version
00ce0dc Use git status instead of diff to add 'WIP' tag
411fd13 Use shfmt v1.3.0 instead of latest from master.
31d069d Change Python shebang to `#!/usr/bin/env python`

git-subtree-dir: tools
git-subtree-split: 74dc626b6de3ffb38591510f7cb7bc2db33743c4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomwilkie tomwilkie

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@peterbourgon @tomwilkie