Skip to content

Commit

Permalink
Merge pull request #3791 from weaveworks/fix-drop-topologies
Browse files Browse the repository at this point in the history
multitenant query: don't drop topologies so much
  • Loading branch information
bboreham authored May 26, 2020
2 parents 7163f42 + a20c51e commit bf90d56
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion app/multitenant/aws_collector.go
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ func registerAWSCollectorMetrics() {
prometheus.MustRegister(reportSizeHistogram)
prometheus.MustRegister(reportsPerUser)
prometheus.MustRegister(reportSizePerUser)
prometheus.MustRegister(topologiesDropped)
prometheus.MustRegister(natsRequests)
flushDuration.Register()
}
Expand Down Expand Up @@ -449,8 +450,12 @@ func (c *awsCollector) getReports(ctx context.Context, userid string, reportKeys
// process a report from a probe which may be at an older version or overloaded
func (c *awsCollector) massageReport(userid string, report report.Report) report.Report {
if c.cfg.MaxTopNodes > 0 {
max := c.cfg.MaxTopNodes
if len(report.Host.Nodes) > 1 {
max = max * len(report.Host.Nodes) // higher limit for merged reports
}
var dropped []string
report, dropped = report.DropTopologiesOver(c.cfg.MaxTopNodes)
report, dropped = report.DropTopologiesOver(max)
for _, name := range dropped {
topologiesDropped.WithLabelValues(userid, name).Inc()
}
Expand Down

0 comments on commit bf90d56

Please sign in to comment.