Merge pull request #453 from weaveworks/452-ellipses

Don't send numeric=true for connections table.
weaveworks · Sep 7, 2015 · 6a6622e · 6a6622e
2 parents 9ab98ba + 303e11b
commit 6a6622e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/render/detailed_node.go b/render/detailed_node.go
@@ -180,7 +180,12 @@ func connectionsTable(connections []Row, r report.Report, n RenderableNode) (Tab
 		rows = append(rows, connections...)
 	}
 	if len(rows) > 0 {
-		return Table{"Connections", true, connectionsRank, rows}, true
+		return Table{
+			Title:   "Connections",
+			Numeric: false,
+			Rank:    connectionsRank,
+			Rows:    rows,
+		}, true
 	}
 	return Table{}, false
 }
@@ -249,6 +254,7 @@ func connectionDetailsRows(topology report.Topology, originID string) []Row {
 		rows = append(rows, Row{
 			Key:        remote,
 			ValueMajor: local,
+			ValueMinor: "",
 			Expandable: true,
 		})
 	}

diff --git a/render/detailed_node_test.go b/render/detailed_node_test.go
@@ -103,7 +103,7 @@ func TestMakeDetailedHostNode(t *testing.T) {
 			},
 			{
 				Title:   "Connections",
-				Numeric: true,
+				Numeric: false,
 				Rank:    0,
 				Rows: []render.Row{
 					{
@@ -179,7 +179,7 @@ func TestMakeDetailedContainerNode(t *testing.T) {
 			},
 			{
 				Title:   "Connections",
-				Numeric: true,
+				Numeric: false,
 				Rank:    0,
 				Rows: []render.Row{
 					{"Egress packet rate", "105", "packets/sec", false},