Skip to content

Commit

Permalink
don't propagate ImageID in MapContainerImage2Name
Browse files Browse the repository at this point in the history
This was building a set of all the image ids represented by the same
unversioned image. Well, it was doing that until I broke it with a
silly mistake in #1739 - instead of extracting the imageID from the
original node ID, it's extracting it from the updated ID, which is the
unversioned image. Even if it was working though, it's pointless
since nothing is looking at that info.
  • Loading branch information
rade committed Dec 28, 2017
1 parent e5fe822 commit 0c726e9
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions render/container.go
Original file line number Diff line number Diff line change
Expand Up @@ -336,10 +336,6 @@ func MapContainerImage2Name(n report.Node) report.Nodes {
imageNameWithoutVersion := docker.ImageNameWithoutVersion(imageName)
n.ID = report.MakeContainerImageNodeID(imageNameWithoutVersion)

if imageID, ok := report.ParseContainerImageNodeID(n.ID); ok {
n.Sets = n.Sets.Add(docker.ImageID, report.MakeStringSet(imageID))
}

return report.Nodes{n.ID: n}
}

Expand Down

0 comments on commit 0c726e9

Please sign in to comment.