Disable secret and configmap caching. #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should reduce the memory consumption of the controller.
|
Makes sense. Surprising that the cache can OOM, like thats gotta be some fairly large / lots and lots of secrets / configmaps. Does controller-runtime expose those metrics? (cache size etc) |
foot
approved these changes
Aug 4, 2023
|
We can't be sure that it's the cache, the data provided says nothing. But, dropping the secret caching, we can at least rule that out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should reduce the memory consumption of the controller.
Same approach (and comment) as weaveworks/gitopssets-controller@943be32
This may help with https://github.com/weaveworks/weave-gitops-interlock/issues/493