Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple bootstraps with different configs. #16

Merged
merged 1 commit into from
Sep 23, 2022

Conversation

bigkevmcd
Copy link
Collaborator

@bigkevmcd bigkevmcd commented Sep 23, 2022

This allows for multiple bootstrap configs to trigger for the same cluster.

The namespace/name of each CBC that has acted is recorded as an annotation on the GitOpsCluster.

This could trigger rebootstraps of existing clusters, but we don't currently have a record of which CBC bootstrapped a cluster.

@bigkevmcd bigkevmcd requested a review from foot September 23, 2022 09:34
Copy link
Collaborator

@foot foot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All makes sense to me! 💯

@@ -29,6 +30,7 @@ import (
"k8s.io/apimachinery/pkg/labels"
"k8s.io/apimachinery/pkg/runtime"
"k8s.io/apimachinery/pkg/types"
"k8s.io/apimachinery/pkg/util/sets"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sets. Very in right now.

This allows for multiple bootstrap configs to trigger for the same
cluster.

The namespace/name of each CBC that has acted is recorded as an
annotation on the GitOpsCluster.

Co-authored-by: Simon <[email protected]>
@bigkevmcd bigkevmcd force-pushed the multi-bootstrap-annotation branch from ec16ee8 to f442912 Compare September 23, 2022 10:05
@bigkevmcd bigkevmcd merged commit d36def5 into main Sep 23, 2022
@bigkevmcd bigkevmcd deleted the multi-bootstrap-annotation branch September 23, 2022 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants