Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint script #163

Merged
merged 3 commits into from
Feb 21, 2020
Merged

Fix lint script #163

merged 3 commits into from
Feb 21, 2020

Conversation

bboreham
Copy link
Contributor

This is a bit embarrasing: CI was running lint (ignoring the . that came after), and that did nothing, so constant success.

Fixing lint to do all directories when called on its own brought up other problems, which are addressed by doing things slightly differently in CI.

We need to make all the sub-projects with the current directory
mounted, so that Go dependencies are present when lint runs.

Then, run lint with a list of directories so it doesn't spew loads of
error messages about those dependencies.
@bboreham bboreham merged commit 4cc7911 into master Feb 21, 2020
@bboreham bboreham deleted the fix-lint branch February 21, 2020 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant