Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): Search on enter #1184

Merged
merged 3 commits into from
Mar 25, 2024
Merged

feat(app): Search on enter #1184

merged 3 commits into from
Mar 25, 2024

Conversation

kuck1
Copy link
Contributor

@kuck1 kuck1 commented Mar 24, 2024

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

  • If there is an autocomplete item, or several, and you press enter, then the top item is searched for

Does this introduce a breaking change?

  • Yes
  • No

Other information

@kuck1 kuck1 requested a review from JoeKarow as a code owner March 24, 2024 23:15
Copy link

vercel bot commented Mar 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
inreach-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 25, 2024 7:37pm

Copy link

alwaysmeticulous bot commented Mar 24, 2024

🤖 No test run has been triggered as your Meticulous project has been deactivated (since you haven't viewed any test results in a while). Click here to reactivate.

Last updated for commit 0dba0ca. This comment will update as new commits are pushed.

Copy link
Contributor

github-actions bot commented Mar 24, 2024

📦 Next.js Bundle Analysis for @weareinreach/app

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@kuck1 kuck1 added the new-feature New features or options. label Mar 25, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@JoeKarow JoeKarow changed the title feat(app) Search on enter feat(app): Search on enter Mar 25, 2024
@kodiakhq kodiakhq bot merged commit 70013b8 into dev Mar 25, 2024
27 of 28 checks passed
@kodiakhq kodiakhq bot deleted the search-on-enter branch March 25, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Enable Kodiak auto-merge kodiak: merge.method = 'squash' Kodiak will squash merge this PR. new-feature New features or options. 📦 ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants