Clearer error message and HIP architectures #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
germasch
requested changes
Dec 20, 2024
Comment on lines
+204
to
+205
| #set(GPU_TARGETS "${HIP_GPU_ARCHITECTURES}" | ||
| # CACHE STRING "GPU targets to compile for") |
There was a problem hiding this comment.
Could you just remove these two lines? I guess it looks like GPU_TARGETS isn't being used at all currently, right?
Comment on lines
+93
to
+96
| hipError_t last_error = hipGetLastError(); | ||
| if (last_error != hipSuccess) { | ||
| fprintf(stderr, "launch failed %s %d, error_code: %d\n", file, line,last_error); | ||
| fprintf(stderr, "(%s)\n", hipGetErrorString(last_error)); |
There was a problem hiding this comment.
Looks good, except that clang-format complains, so please update the formatting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
macros.hfile, the error message is added to the error code.CMAKE_HIP_ARCHITECTURESvariable to set the hip architecture for AMD GPUs.