-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Step to newer rocm versions and vendor independent naming #292
Conversation
Have you tested this with ROCM 5.5 and < 5.5? The include change happened in 5.5. I tried changing the ifs to check for 5.5 and later, and it still fails to compile tests even with Given that GENE is probably the only user of this, do we need to support ROCM <5.5 or even <6? If we do, then I want to make sure we can verify it works, otherwise we can just assume the new include paths and not worry about backward compat. |
Got it working with ROCm 5.5, was a configuration issue on my end. The dir structure changed in 5.5 and it has backward compatibility, but the backward compatibility is fragile. In particular, HIP_PATH need to be set to same as ROCM_PATH instead of ROCM_PATH/hip, that avoids all the warnings from the distributed header files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you for the contribution!
We can also consider removing the <5.5. compatibility in the future.
This PR