update sycl_ext_complex #239
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bd4
force-pushed
the
pr/new-sycl-ext
branch
6 times, most recently
from
05b0bc2 to
a667552
Compare
For some reason the gtensor specified AssignN kernel names were missing the second sycl_cplx::complex type arg, and failed to compile. Using only the to_kernel types fixes the issue, and also makes the names more compact and easier to read. I don't think they are actually necessary to avoid duplication, the kernel types alone should be unique.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that for some reason the gtensor specified AssignN kernel names no longer work with the additional template parameter on sycl ext complex type; the name is missing the void parameter on some names in the kernel and it appears to be a phase where the default parameter can't be inserted, and it fails to compile.