read with padding and specialize u8 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharksforarms
commented
Sep 30, 2022
sharksforarms
commented
Sep 30, 2022
| let bytes: &[u8] = bit_slice.as_raw_slice(); | ||
| let pad = 8 * ((bit_slice.len() + 7) / 8) - bit_slice.len(); | ||
|
|
||
| // TODO: mention that this is slow? a conditional should be fast... |
There was a problem hiding this comment.
fyi, I don't think this path is slow (it's just comparing numbers), I think it's more-so the allocation that we save with the specialization of bytes (try running test_alloc with the changes in this branch on master, we save an alloc + realloc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this passes the tests, but there are some improvements to be made I think regarding the macro handling (duplicated code for specializing u8, we can probably split this out)
as well as figuring out where those alloc/realloc is coming from(edit: this was from my debugging printlns oops)