Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make "-v" argument-regexp match complete string #64

Merged
merged 1 commit into from
Sep 17, 2022
Merged

Make "-v" argument-regexp match complete string #64

merged 1 commit into from
Sep 17, 2022

Conversation

juergenhoetzel
Copy link
Contributor

Prevents invalid substring matches for "--verbose --verbose" init value.

Closes #63.

@juergenhoetzel juergenhoetzel mentioned this pull request Sep 17, 2022
Closed
wbolster
wbolster reviewed Sep 17, 2022
View reviewed changes
python-pytest.el Outdated Show resolved Hide resolved
wbolster
wbolster reviewed Sep 17, 2022
View reviewed changes
Copy link
Owner

@wbolster wbolster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit; lgtm otherwise

@juergenhoetzel
Make "-v" argument-regexp match complete string
effa368 
Prevents invalid substring matches for "--verbose --verbose" init
value.

Closes wbolster#63.
@wbolster wbolster merged commit bec1483 into wbolster:main Sep 17, 2022
@wbolster
Copy link
Owner

thanks!

@sammorley-short
Copy link

I've updated my packages (I use doom emacs, so via doom upgrade) and this doesn't seem to have worked for me. Does there need to be a new release for the package to deploy this? Thanks!

@wbolster
Copy link
Owner

@sammorley-short you should be able to check this yourself: is the 1 line change (see diff for thsi pull request) present in your local copy of that file?

@sammorley-short
Copy link

I don't. I have ran doom upgrade multiple times, and have also deleted all my packages in .local/straight/ and pulled them all again.

Am I doing something wrong here?

@wbolster
Copy link
Owner

are you using only melpa stable packages perhaps?

if so, this may help: i just tagged a 3.3.0 release (because why not) which should appear on melpa stable soon. see https://github.com/wbolster/emacs-python-pytest/releases/tag/3.3.0

@wbolster wbolster added the bug Something isn't working label Oct 21, 2022
@sammorley-short
Copy link

Yep, that's fixed it now. Thanks all! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbolster wbolster wbolster approved these changes

Assignees

@juergenhoetzel juergenhoetzel

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Double verbosity setting saving broken
3 participants
@juergenhoetzel @wbolster @sammorley-short