Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TypeError in FIM Inventory using new error-handler #5268

Closed
wants to merge 76 commits into from
Closed

Fix TypeError in FIM Inventory using new error-handler #5268

wants to merge 76 commits into from

Conversation

Machi3mfl
Copy link
Member

@Machi3mfl Machi3mfl commented Mar 7, 2023 •
edited
Loading

Description

This PR, solves and unhandled TypeError adding the new error management solution.

Closes #5210

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Machi3mfl and others added 30 commits February 10, 2023 09:25
@Machi3mfl
Fixed catch error throw string instead error
0d91d7e
@Machi3mfl
Added ErrorFactory with tests
2aea797
@Machi3mfl
Implemented ErrorFactory on generic-request and tests
a81f72b
@Machi3mfl
Fixed tests
676017e
@Machi3mfl
Refactored errorfactory for create differents error types
4da0585
@Machi3mfl
Added prevent create new error when it is
d365edd
@Machi3mfl
Added error factory in wz-request
b6ce3a6
@Machi3mfl
Added error factory in wz-api-check
f5ab382
@Machi3mfl
Added error factory in saved-objects and tests
87960af
@Machi3mfl
Changed wz-api-check for typescript file
b299ef6
@Machi3mfl
Refactoring error factory
a28caa9
@Machi3mfl
Fixed generic-request test
025de8f
@Machi3mfl
Added Settings Controller tests for onInit event
2a8cb71
@Machi3mfl
Edited ErrorFactory createError
799896f
@Machi3mfl
Added check api service tests
8b2a9a4
@Machi3mfl
Moved error factory files
b4c8cc5
@Machi3mfl
Added error-handler with new implementation
c4e652c
@Machi3mfl
Fixed types and unit tests
1b1cbc5
@Machi3mfl
Skiped some unit tests
c3e524f
@Machi3mfl
Skiped react services unit tests
7f231d0
@Machi3mfl
Added unit test to return error in error handler
d1da398
@Machi3mfl
Added new errors classes relantionship
438db5f
@Machi3mfl
Resolved conflict
827df59
@Machi3mfl
Reordered folder structure
a0ac98c
@Machi3mfl
Added error factory unit test for every error classes
e189713
@Machi3mfl
Added error handler unit tests
58ebed6
@Machi3mfl
Fixed and skipped some errors
185fa9e
@Machi3mfl
Updated hook and hoc unit tests
b749fc0
@Machi3mfl
Restoring services state
61dc820
@Machi3mfl
Added README
86577b9
@Machi3mfl Machi3mfl requested a review from a team as a code owner March 7, 2023 16:55
@Machi3mfl Machi3mfl changed the title Added error handler in file detail Fixed TypeError in FIM Inventory using new error-handler Mar 7, 2023
@Machi3mfl Machi3mfl linked an issue Mar 7, 2023 that may be closed by this pull request
Uncaught (in promise) TypeError in Integrity monitoring inventory #5210
Closed
@AlexRuiz7 AlexRuiz7 force-pushed the feat/4145-request-errors-management branch from 79e1118 to 9a8d075 Compare March 9, 2023 12:23
@AlexRuiz7 AlexRuiz7 changed the title Fixed TypeError in FIM Inventory using new error-handler Fix TypeError in FIM Inventory using new error-handler Mar 9, 2023
@Machi3mfl Machi3mfl changed the title Fix TypeError in FIM Inventory using new error-handler Fixed TypeError in FIM Inventory using new error-handler Mar 15, 2023
@Machi3mfl Machi3mfl changed the title Fixed TypeError in FIM Inventory using new error-handler Fix TypeError in FIM Inventory using new error-handler Mar 15, 2023
@Machi3mfl
Copy link
Member Author

Machi3mfl commented Mar 22, 2023 •
edited
Loading

Generate test cases (In progress)

  • Add and document e2e tests (mocked environment) to make more easier the code review and testing.

@Desvelao
Copy link
Member

question: I am not sure why this pull request has so much commits. Did you use another base branch instead the target branch of the pull request to the fix/feature?

Desvelao
Desvelao reviewed Mar 23, 2023
View reviewed changes
@Machi3mfl Machi3mfl force-pushed the fix/5210-error-management-in-typeerror branch 2 times, most recently from 4192c76 to 1f13503 Compare April 4, 2023 15:02
yenienserrano
yenienserrano approved these changes Apr 10, 2023
View reviewed changes
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tostti
Tostti reviewed Apr 10, 2023
View reviewed changes
Copy link
Member

@Tostti Tostti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imagen

The PR contains a huge amount of commits, is that correct? Additionaly, there are several unsigned commits

TEST:🟢
CR: 🟢
PR: 🟡

@Machi3mfl
Copy link
Member Author

I closed this PR because the first commits are wrong. I create a new PR with the corrects commits and changes.
New PR solving the same issue: #5364

@Machi3mfl Machi3mfl closed this Apr 11, 2023
@Machi3mfl Machi3mfl deleted the fix/5210-error-management-in-typeerror branch April 11, 2023 11:28
@Tostti Tostti removed a link to an issue Apr 11, 2023
Uncaught (in promise) TypeError in Integrity monitoring inventory #5210
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Desvelao Desvelao Desvelao left review comments

@Tostti Tostti Tostti left review comments

@yenienserrano yenienserrano yenienserrano approved these changes

Assignees

@Machi3mfl Machi3mfl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Machi3mfl @Desvelao @Tostti @yenienserrano @AlexRuiz7