Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Centralized restart service #5085

Closed
wants to merge 84 commits into from
Closed

Centralized restart service #5085

wants to merge 84 commits into from

Conversation

yenienserrano
Copy link
Member

Description:

The way to restart the manager or cluster was centralized in a service since each view that had the option to restart did it differently.

In order to allow the cluster to synchronize ruleset changes, a delay was applied before restarting Wazuh. This delay has been removed as it's been replaced by a polling system, so it's no longer required. The app will ping the Wazuh API and wait until it's back up again. If this does not happen, the app will show an error message, as the API did not come back online.

Due to the changes of this development, code has been removed as it was no longer used.

PR above with more information (a revert was made):

Issue:

Test:

To test it you have to go to any page that has the restart option and try doing the restart, when it tells you that it has restarted try navigating between pages that make requests to the API.

Successful restart

  1. Navigate to one of the following sections:
  • Management > Configuration > Edit configuration
  • Management > Status
  • Management > Rules and edit file
  • Management > Decoders and edit file
  • Management > CDB lists and edit file
  1. Click on the restart button and wait until it's done.
  2. Navigate to another route that uses some request for the API, and check that no error is thrown.

Restart failure

  1. Navigate to one of the following sections:
  • Management > Configuration > Edit configuration
  • Management > Status
  • Management > Rules and edit file
  • Management > Decoders and edit file
  • Management > CDB lists and edit file
  1. Click on the restart button and wait until it's done.
  2. Once the first polling cycle is done, disconnect the manager from the app (in Docker, stop the container).
  3. Wait until the modal changes state, showing that the restart has failed. A button to redirect to the Healthcheck must also appear. Check this button works properly.

Screenshot:

Ongoing restart:

image

Successfully restarted:

image

Restart error:

image

Cluster synchronization:

image

Cluster synchronization error:

image

yenienserrano and others added 30 commits August 12, 2022 17:22
@yenienserrano @github-actions
Create service to restart wazuh (#4365)
27e06fb 
* file to be added with the restart functions

* restart calls were changed to service calls

* the restarting on time sign appears

* modal while restarting added

* countDown change of location

* cleaning

* modal redesign

* model and code update

* modified delays and designs

* change text Synchronizing cluster

* Update restart-cluster-manager-callout.tsx

* Code improvements

* suggestions implemented

* polling sync add

* Code improvements

* add endpoint

* add comment

* add close button

* suggestions implemented

* add modal wazuh restarted

* delete unnecessary toast

* Set clearState on restart error

* disabled unneeded console.log

Co-authored-by: Alex Ruiz Becerra <[email protected]>
Co-authored-by: Federico Rodriguez <[email protected]>
Co-authored-by: chantal.kelm <[email protected]>
(cherry picked from commit 6598df9)
@chantal-kelm
Updated Changelog
b95aa45
@github-actions @yenienserrano @chantal-kelm
[Backport 4.3-1.2-wzd] Create service to restart wazuh (#4395)
eb89062 
* Create service to restart wazuh (#4365)

* file to be added with the restart functions

* restart calls were changed to service calls

* the restarting on time sign appears

* modal while restarting added

* countDown change of location

* cleaning

* modal redesign

* model and code update

* modified delays and designs

* change text Synchronizing cluster

* Update restart-cluster-manager-callout.tsx

* Code improvements

* suggestions implemented

* polling sync add

* Code improvements

* add endpoint

* add comment

* add close button

* suggestions implemented

* add modal wazuh restarted

* delete unnecessary toast

* Set clearState on restart error

* disabled unneeded console.log

Co-authored-by: Alex Ruiz Becerra <[email protected]>
Co-authored-by: Federico Rodriguez <[email protected]>
Co-authored-by: chantal.kelm <[email protected]>
(cherry picked from commit 6598df9)

* Updated Changelog

Co-authored-by: Ian Yenien Serrano <[email protected]>
Co-authored-by: Chantal Belén kelm <[email protected]>
@Desvelao @matiasmoreno876
Fixed a routes loop when reinstalling Wazuh indexer (#4373)
be7654a 
* fix: Fixed a routes loop when reinstalling Wazuh indexer

* fix: replaced the display error in the plugin loop

* changelog: add PR entry

* fix import variable

Co-authored-by: Matias Ezequiel Moreno <[email protected]>
@matiasmoreno876
Version bump v4.3.7-1.2.0-wzd
2bf803e
@github-actions @yenienserrano
[Backport 4.3-1.2-wzd] Moved the file config-equivalences to common (#…
3c48aab 
…4401)

Moved the file config-equivalences to common (#4399)

* common/config-equivalences

* add changelog

(cherry picked from commit a40a2ae)

Co-authored-by: Ian Yenien Serrano <[email protected]>
@yenienserrano
change revision
f7e4518
@yenienserrano
Revert "[Backport 4.3-1.2-wzd] Create service to restart wazuh (#4395)"
2f5fef4 
This reverts commit eb89062.
@yenienserrano
changing design
8f67486
@yenienserrano
add files
69627cb
@yenienserrano
changing design sync
e7e7ebd
@yenienserrano
restart modal redesign
0008851
@yenienserrano
finished design and lint
633f2bb
@yenienserrano
finished design and lint
035a432 
Signed-off-by: yenienserrano <[email protected]>
@yenienserrano
Add some test
046c4d9
@AlexRuiz7
Merge branch '4.4-1.2-wzd' into backport-4365-to-4.3-1.2-wzd
00353f7
@yenienserrano
Create service to restart wazuh (#4365)
ba6a27c 
* file to be added with the restart functions

* restart calls were changed to service calls

* the restarting on time sign appears

* modal while restarting added

* countDown change of location

* cleaning

* modal redesign

* model and code update

* modified delays and designs

* change text Synchronizing cluster

* Update restart-cluster-manager-callout.tsx

* Code improvements

* suggestions implemented

* polling sync add

* Code improvements

* add endpoint

* add comment

* add close button

* suggestions implemented

* add modal wazuh restarted

* delete unnecessary toast

* Set clearState on restart error

* disabled unneeded console.log

Co-authored-by: Alex Ruiz Becerra <[email protected]>
Co-authored-by: Federico Rodriguez <[email protected]>
Co-authored-by: chantal.kelm <[email protected]>
(cherry picked from commit 6598df9)
@chantal-kelm @yenienserrano
Updated Changelog
556d87d
@yenienserrano
changing design
26c38fc
@yenienserrano
add files
77c376e
@yenienserrano
changing design sync
7920fa7
@yenienserrano
restart modal redesign
fc3f9d6
@yenienserrano
finished design and lint
3a9b7a9
@yenienserrano
finished design and lint
3e89eb5 
Signed-off-by: yenienserrano <[email protected]>
@yenienserrano
Add some test
79daa1c
@Desvelao @yenienserrano
bump: Wazuh 4.4.0
4b9875d
@AlexRuiz7 @mcarmona99 @yenienserrano
Use POST method when requesting the API login endpoint (#4103) (#4320)
8119a63 
* Use POST method when requesting the API login endpoint

* changelog: add PR entry

Co-authored-by: Matias Ezequiel Moreno <[email protected]>
Co-authored-by: Álex <[email protected]>
Co-authored-by: Antonio David Gutiérrez <[email protected]>
(cherry picked from commit 3977e45)

Co-authored-by: Manuel Carmona Pérez <[email protected]>
@github-actions @Machi3mfl @yenienserrano
[Backport 4.4-1.2-wzd] Added new key request block in Registration se…
5e230e4 
…rvice config (#4322)

Added new key request block in Registration service config (#3956)

* Added new key request block

* Removed failed snapshots

* Updated some test snapshots

* Updated descriptions registration-service

(cherry picked from commit 2b6ecf3)

Co-authored-by: Maximiliano Ibarra <[email protected]>
@github-actions @yenienserrano
[Backport 4.4-1.2-wzd] Sorting by agents in the table groups (#4339)
15652d5 
Sorting by agents in the table groups (#4323)

* Added sortable by agent count option to the groups table

* Added changelog entry

Co-authored-by: Álex <[email protected]>
(cherry picked from commit 9079f07)

Co-authored-by: Ian Yenien Serrano <[email protected]>
@Desvelao @yenienserrano
fix: fixed parameter type in server controller
ea59835
yenienserrano and others added 16 commits September 6, 2022 10:35
@yenienserrano
Merge branch 'backport-4365-to-4.3-1.2-wzd' of https://github.com/waz…
178202d 
…uh/wazuh-kibana-app into backport-4365-to-4.3-1.2-wzd
@AlexRuiz7
Initialize tests for wz-restart.ts
736db4b
@yenienserrano
merge 4.4-1.2-wzd
078d14b
@yenienserrano
Delete package-lock.json
0c8e6b7
@yenienserrano
restore registration-service.js
5a6b8b8
@yenienserrano
Delete actions-buttons.js
78a6663
@yenienserrano
Delete ruleset-overview.js
e5245a5
@yenienserrano
fix error rebase
92fefe4
@yenienserrano
fix merge bug
672f59a
@yenienserrano
added default value 'isSyncCanceled: false'
3380b9e
@yenienserrano
remove console.log
11636b5
@yenienserrano
text modal changed
6ac94a1
@AlexRuiz7
Merge branch '4.4-1.2-wzd' into backport-4365-to-4.3-1.2-wzd
7c33058
@yenienserrano
Merge branch '4.4-2.4-wzd' into 4277-centralized-restart-service-4.3-…
342063f 
…1.2-wzd
@yenienserrano
Update CHANGELOG.md
5ccbee7
@yenienserrano
Merge branch '4.4-2.4-wzd' into 4277-centralized-restart-service-4.3-…
ad273eb 
…1.2-wzd
@yenienserrano yenienserrano linked an issue Feb 6, 2023 that may be closed by this pull request
Centralized service to restart Wazuh #4277
Closed
@yenienserrano yenienserrano changed the base branch from 4.4-2.4-wzd to 4.5 February 9, 2023 08:15
@github-actions
Copy link
Contributor

Code coverage (Jest) % values
Statements 9.17% ( 3394 / 37001 )
Branches 4.72% ( 1354 / 28648 )
Functions 8.01% ( 735 / 9176 )
Lines 9.23% ( 3273 / 35429 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@yenienserrano yenienserrano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Centralized service to restart Wazuh
5 participants
@yenienserrano @chantal-kelm @Desvelao @matiasmoreno876 @AlexRuiz7