Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test cases and fix for PR 4418 and 4416 for directory changes #4432

Conversation

mauceballos
Copy link
Contributor

this PR include the following PR's:

#4418
#4416

and fixes for

remove-filter-from-module-dashboard.feature
remove-filter-from-module-event.feature

@Mayons95
Copy link
Contributor

I'm going to test yours PR on WZD Dashboard.
Thanks @mauceballos

@Mayons95 Mayons95 self-requested a review August 31, 2022 18:02
@Mayons95
Copy link
Contributor

Please review WZD Selectors, these were working before this PR
Screenshot from 2022-08-31 15-01-54

Copy link
Contributor

@Mayons95 Mayons95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the comments on the PR

Copy link
Contributor

@matiasmoreno876 matiasmoreno876 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matiasmoreno876 matiasmoreno876 merged commit 2b27613 into feature/migrate-wazuh-cypress Sep 1, 2022
@matiasmoreno876 matiasmoreno876 deleted the 4424-wrong-scenario-for-remove-filter branch September 1, 2022 17:26
matiasmoreno876 added a commit that referenced this pull request Sep 2, 2022
* migrate wazuh cypress

* deleted workflow

* updated workflow for docker images

* deleted reports files

* updated workflows

* update workflow

* added new files

* Delete .DS_Store

* changed directory

* updated dockerfile

* add test cases and fix for PR 4418 and 4416 for directory changes (#4432)

* add test cases and fix for PR 4418 and 4416 for directory changes

* rollback decoders.page.js file for wzd

Co-authored-by: mauceballos <[email protected]>
github-actions bot pushed a commit that referenced this pull request Sep 2, 2022
* migrate wazuh cypress

* deleted workflow

* updated workflow for docker images

* deleted reports files

* updated workflows

* update workflow

* added new files

* Delete .DS_Store

* changed directory

* updated dockerfile

* add test cases and fix for PR 4418 and 4416 for directory changes (#4432)

* add test cases and fix for PR 4418 and 4416 for directory changes

* rollback decoders.page.js file for wzd

Co-authored-by: mauceballos <[email protected]>
(cherry picked from commit e856b0b)
matiasmoreno876 added a commit that referenced this pull request Sep 2, 2022
Migrate wazuh cypress (#4344)

* migrate wazuh cypress

* deleted workflow

* updated workflow for docker images

* deleted reports files

* updated workflows

* update workflow

* added new files

* Delete .DS_Store

* changed directory

* updated dockerfile

* add test cases and fix for PR 4418 and 4416 for directory changes (#4432)

* add test cases and fix for PR 4418 and 4416 for directory changes

* rollback decoders.page.js file for wzd

Co-authored-by: mauceballos <[email protected]>
(cherry picked from commit e856b0b)

Co-authored-by: Matias Ezequiel Moreno <[email protected]>
@mauceballos mauceballos linked an issue Sep 7, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation automation type/test Test issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong Scenario for remove filter from module dashboard
3 participants