Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question - configure resolution by minor axis/height rather than width #57

Open
caurnaudthia opened this issue Mar 6, 2025 · 8 comments
Labels
enhancement New feature or request

Comments

@caurnaudthia
Copy link

caurnaudthia commented Mar 6, 2025

Hello! Thank you so much for the wonderful project! It works great and I have enjoyed using it thus far. This also isn't a bug report and is more of a general question. I was just wondering if there was any way I can change the way resolution was specified for the files because I shoot panoramas, whose aspect ratio means that specifying a maximum width would oversize normal landscape and vastly oversize portrait shots. I would optimally be able to have all my shots come out on the preview at a decent preview quality rather than needing to decide between having my website load slower due to inflated file sizes or have low quality previews on panoramas. Again, I am sorry for bothering you, and I hope you have a wonderful day!

Best,
Wisteria

@waynezhang waynezhang added the enhancement New feature or request label Mar 6, 2025
@waynezhang
Copy link
Owner

@caurnaudthia hi, thanks for the question! Currently there is no way to do this but I think this is a good suggestion. I’ll take a look at it and probably add a new config for this.

@caurnaudthia
Copy link
Author

thank you so much for everything!

@caurnaudthia
Copy link
Author

wait i clicked the wrong button haha

@waynezhang waynezhang reopened this Mar 8, 2025
waynezhang added a commit that referenced this issue Mar 9, 2025
waynezhang added a commit that referenced this issue Mar 9, 2025
* chore: go version up

* feat: #57 add height setting

* chore: update foto.toml

* feat: allow image size override per section
waynezhang added a commit that referenced this issue Mar 9, 2025
…tion

* chore: go version up

* feat: #57 add height setting

* chore: update foto.toml

* feat: allow image size override per section
@waynezhang
Copy link
Owner

@caurnaudthia hi, I just released 1.6.0 that supports height setting and section override. Please check the updated configuration file.

@waynezhang
Copy link
Owner

Hmm this still is not a perfect solution if you mix the portraits and panoramas in the same section. I guess it needs more effort. Let me take some time to think about this.

@waynezhang
Copy link
Owner

A combination of width and minHeight might do the work.

@waynezhang
Copy link
Owner

@caurnaudthia I just removed height settings and added min height settings in v1.6.1. Please take a look at it.

@caurnaudthia
Copy link
Author

alright, thank you so much I'll try it as soon as I can!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants