Leave Time in local time zone #460
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That sounds reasonable, but I'm not sure (haven't been hands on for a while with this gem); and I can see problems with casting time to UTC but not date as we have in the current code. Might defer to other reviewers for input. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been on a bit of a quest to figure out how to convert UTC timestamps into the correct dates for invoices and payments. I'd tried using time zone hash I'd posted on #458 along with Rails' time zone extensions to set the dates to a
Timein the organization's time zone assuming that would end up as the correct... but strangely it kept using the UTC time... eventually I found where theTimes andDates are serialized into XML and discovered my hard work was being undone.Since Xero doesn't use any time or time zone component for it's date fields I don't think we should be converting them to UTC before saving them. So this PR removes that.
My temporary work around is put the Time into the right time zone then call
to_dateso there's no further conversion before it's serialized into XML.