Storage Default Object ACL resource #1
Conversation
| Creates a new default object ACL in Google Cloud Storage. | ||
| --- | ||
|
|
||
| # google\_storage\_object\_acl |
There was a problem hiding this comment.
This should be google_storage_default_object_acl.
| resource.TestStep{ | ||
| Config: testGoogleStorageDefaultObjectsAclBasic1(bucketName), | ||
| Check: resource.ComposeTestCheckFunc( | ||
| testAccCheckGoogleStorageDefaultObjectAcl(bucketName, roleEntityBasic1), |
There was a problem hiding this comment.
I think you forgot to copy/paste the variables for roleEntity... into the test file?
There was a problem hiding this comment.
I did it on purpose: i'm using the roleEntity variable definitions from resource_storage_bucket_acl_test.go. This permissions set is fine to use for testing purposes for all ACL resources.
Besides, all the tests are passing:
make testacc TEST=./google TESTARGS='-run=TestAccGoogleStorageDefaultObjectAcl'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./google -v -run=TestAccGoogleStorageDefaultObjectAcl -timeout 120m
=== RUN TestAccGoogleStorageDefaultObjectAcl_basic
=== RUN TestAccGoogleStorageDefaultObjectAcl_upgrade
=== RUN TestAccGoogleStorageDefaultObjectAcl_downgrade
--- PASS: TestAccGoogleStorageDefaultObjectAcl_basic (14.37s)
--- PASS: TestAccGoogleStorageDefaultObjectAcl_upgrade (24.78s)
--- PASS: TestAccGoogleStorageDefaultObjectAcl_downgrade (25.00s)
PASS
ok github.com/terraform-providers/terraform-provider-google/google 25.240s
There was a problem hiding this comment.
Oh, right. Sorry, I was forgetting that those variables would be exposed at the module level. When I didn't see them in your file, I got very confused. :)
| } | ||
|
|
||
| func getDefaultObjectAclId(bucket string) string { | ||
| return bucket + "-default-acl" |
There was a problem hiding this comment.
should we make it bucket + "-default-object-acl"?
There was a problem hiding this comment.
Merged upstream into the fork.
I tried to make it consistent with object_acl resource, where they ID object + "-acl" but since it's a bucket level change, I think you are right it will be, more staright forward if we add object in there. changing to "-default-object-acl".
Logging seems consistent to me. Added a small change
|
@amoiseiev, I merged upstream into our fork and my branch. Also confirmed the logging and made some minor changes |
|
@ishashchuk merged. Thank you. Let's try upstream now |
This addresses issue #67
It's very similar to an existing resource for storage_object_acl, with the exception of setting up permissions on the bucket level. Link to API can be found in the DOC portion, but also can be quickly viewed here