-
Notifications
You must be signed in to change notification settings - Fork 826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v3.2.0 #678
Release v3.2.0 #678
Conversation
…header and results
Codecov Report
@@ Coverage Diff @@
## master #678 +/- ##
==========================================
- Coverage 35.69% 35.16% -0.54%
==========================================
Files 24 24
Lines 18807 19294 +487
==========================================
+ Hits 6714 6785 +71
- Misses 12093 12509 +416
Continue to review full report at Codecov.
|
ibm_watson/compare_comply_v1.py
Outdated
payment_terms=None, | ||
tables=None, | ||
document_structure=None, | ||
parties=None): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Erika does order matter here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 looks good overall! Not sure how much of an issue the param order change in the models are. Ill approve in case they aren't an issue. When you're done can you update https://github.ibm.com/Watson/developer-experience/wiki/Generation-and-Release-times
@@ -1671,6 +1675,7 @@ def __init__(self, | |||
type=None, | |||
text=None, | |||
relevance=None, | |||
confidence=None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be on the bottom?
ibm_watson/speech_to_text_v1.py
Outdated
@@ -2938,6 +2963,7 @@ class AcousticModel(object): | |||
def __init__(self, | |||
customization_id, | |||
created=None, | |||
updated=None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
param order change
ibm_watson/speech_to_text_v1.py
Outdated
@@ -4555,6 +4597,7 @@ class LanguageModel(object): | |||
def __init__(self, | |||
customization_id, | |||
created=None, | |||
updated=None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
another order change
ibm_watson/speech_to_text_v1.py
Outdated
@@ -5914,6 +5969,7 @@ def __init__(self, | |||
results=None, | |||
result_index=None, | |||
speaker_labels=None, | |||
processing_metrics=None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
order change?
🎉 This PR is included in version 3.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
3.2.0
Bug Fixes
Features