Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v3.2.0 #678

Merged
merged 17 commits into from
Jul 24, 2019
Merged

Release v3.2.0 #678

merged 17 commits into from
Jul 24, 2019

Conversation

ehdsouza
Copy link
Contributor

3.2.0

Bug Fixes

* readme: fix project's long_description has invalid markup (c8aa157 (https://github.com/watson-developer-cloud/python-sdk/commit/c8aa157))
* fixes https://github.com/watson-developer-cloud/python-sdk/issues/676

Features

* assistantv2: DialogRuntimeResponseGeneric model has new params header and results (9d9a85a (https://github.com/watson-developer-cloud/python-sdk/commit/9d9a85a))
* compare comply: Basic auth support for compare and comply (ad624bb (https://github.com/watson-developer-cloud/python-sdk/commit/ad624bb))
* compare comply: ClassifyReturn model changes (a20c81e (https://github.com/watson-developer-cloud/python-sdk/commit/a20c81e))
* compare comply: ClassifyReturn model updates (612b8ba (https://github.com/watson-developer-cloud/python-sdk/commit/612b8ba))
* compare comply: model changes (e14b93d (https://github.com/watson-developer-cloud/python-sdk/commit/e14b93d))
* NLU: NLU Confidence field in EntitesResult and EntityMention (7a915f5 (https://github.com/watson-developer-cloud/python-sdk/commit/7a915f5))
* speech to text: AcousticModel & LanguageModel have updated field (306e42a (https://github.com/watson-developer-cloud/python-sdk/commit/306e42a))
* speech to text: ProcessingMetrics has processing_metrics field (482ccd6 (https://github.com/watson-developer-cloud/python-sdk/commit/482ccd6))

@ehdsouza ehdsouza changed the title Version 3.2 Release v3.2.0 Jul 23, 2019
@ehdsouza ehdsouza requested a review from mediumTaj July 23, 2019 20:02
@codecov-io
Copy link

codecov-io commented Jul 23, 2019

Codecov Report

Merging #678 into master will decrease coverage by 0.53%.
The diff coverage is 16.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #678      +/-   ##
==========================================
- Coverage   35.69%   35.16%   -0.54%     
==========================================
  Files          24       24              
  Lines       18807    19294     +487     
==========================================
+ Hits         6714     6785      +71     
- Misses      12093    12509     +416
Impacted Files Coverage Δ
ibm_watson/text_to_speech_v1.py 46.19% <ø> (ø) ⬆️
ibm_watson/personality_insights_v3.py 44.91% <ø> (ø) ⬆️
ibm_watson/assistant_v1.py 42.45% <ø> (ø) ⬆️
ibm_watson/language_translator_v3.py 57.28% <ø> (ø) ⬆️
ibm_watson/assistant_v2.py 24.72% <15.49%> (-1.51%) ⬇️
ibm_watson/compare_comply_v1.py 28.02% <17.06%> (-1.66%) ⬇️
ibm_watson/speech_to_text_v1.py 33.18% <7.14%> (-0.26%) ⬇️
ibm_watson/natural_language_understanding_v1.py 27.13% <8.33%> (-0.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0892fd7...6d6b0c0. Read the comment docs.

payment_terms=None,
tables=None,
document_structure=None,
parties=None):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Erika does order matter here?

Copy link
Contributor

@mediumTaj mediumTaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good overall! Not sure how much of an issue the param order change in the models are. Ill approve in case they aren't an issue. When you're done can you update https://github.ibm.com/Watson/developer-experience/wiki/Generation-and-Release-times

@@ -1671,6 +1675,7 @@ def __init__(self,
type=None,
text=None,
relevance=None,
confidence=None,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be on the bottom?

@@ -2938,6 +2963,7 @@ class AcousticModel(object):
def __init__(self,
customization_id,
created=None,
updated=None,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

param order change

@@ -4555,6 +4597,7 @@ class LanguageModel(object):
def __init__(self,
customization_id,
created=None,
updated=None,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another order change

@@ -5914,6 +5969,7 @@ def __init__(self,
results=None,
result_index=None,
speaker_labels=None,
processing_metrics=None,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

order change?

@ehdsouza ehdsouza merged commit 563200b into master Jul 24, 2019
@ehdsouza ehdsouza deleted the version-3.2 branch July 24, 2019 18:56
@watson-github-bot
Copy link
Member

🎉 This PR is included in version 3.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants