Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Assistantv1): Apply manual changes for CreateDialogNode #619

Merged
merged 2 commits into from
Dec 21, 2018
Merged

fix(Assistantv1): Apply manual changes for CreateDialogNode #619

merged 2 commits into from
Dec 21, 2018

Conversation

ehdsouza
Copy link
Contributor

fixes #618

@ehdsouza ehdsouza requested a review from mediumTaj December 20, 2018 17:04
germanattanasio
germanattanasio approved these changes Dec 20, 2018
View reviewed changes
Copy link
Contributor

@germanattanasio germanattanasio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

mediumTaj
mediumTaj approved these changes Dec 20, 2018
View reviewed changes
Copy link
Contributor

@mediumTaj mediumTaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good!

@codecov-io
Copy link

codecov-io commented Dec 21, 2018 •
edited
Loading

Codecov Report

Merging #619 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #619      +/-   ##
=========================================
+ Coverage    37.9%   37.9%   +<.01%     
=========================================
  Files          28      28              
  Lines       19422   19427       +5     
=========================================
+ Hits         7361    7363       +2     
- Misses      12061   12064       +3
Impacted Files Coverage Δ
watson_developer_cloud/assistant_v1.py 39.77% <0%> (-0.07%) ⬇️
watson_developer_cloud/watson_service.py 78.03% <0%> (+0.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cc893c...c8f93b3. Read the comment docs.

@ehdsouza ehdsouza merged commit 63330a7 into master Dec 21, 2018
@ehdsouza ehdsouza deleted the assistant-patch branch December 21, 2018 06:04
@watson-github-bot
Copy link
Member

🎉 This PR is included in version 2.5.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@germanattanasio germanattanasio germanattanasio approved these changes

@mediumTaj mediumTaj mediumTaj approved these changes

Assignees
No one assigned
Labels
Ready for review released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Workspace Bug - missing "disabled" field in node model for MCR
5 participants
@ehdsouza @codecov-io @watson-github-bot @germanattanasio @mediumTaj