Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle deserialization of empty responses #600

Merged
merged 1 commit into from
Nov 20, 2018
Merged

handle deserialization of empty responses #600

merged 1 commit into from
Nov 20, 2018

Conversation

ehdsouza
Copy link
Contributor

fixes: #599

@ehdsouza ehdsouza requested a review from mediumTaj November 20, 2018 20:59
@codecov-io
Copy link

codecov-io commented Nov 20, 2018 •
edited
Loading

Codecov Report

Merging #600 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #600   +/-   ##
======================================
  Coverage       0%      0%           
======================================
  Files          26      26           
  Lines       17181   17184    +3     
======================================
- Misses      17181   17184    +3
Impacted Files Coverage Δ
watson_developer_cloud/watson_service.py 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2946d1...cf17bf3. Read the comment docs.

mediumTaj
mediumTaj approved these changes Nov 20, 2018
View reviewed changes
Copy link
Contributor

@mediumTaj mediumTaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good!

@ehdsouza ehdsouza merged commit 6e6d4aa into master Nov 20, 2018
@ehdsouza ehdsouza deleted the fix-no-text branch November 20, 2018 21:40
@watson-github-bot
Copy link
Member

🎉 This PR is included in version 2.4.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mediumTaj mediumTaj mediumTaj approved these changes

Assignees
No one assigned
Labels
Ready for review released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JSONDecodeError on STT unregister_callback
4 participants
@ehdsouza @codecov-io @watson-github-bot @mediumTaj