Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the way to load Azure.Core assemblies for Storage #7

Merged
merged 2 commits into from
Apr 9, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/Storage/Storage.Management/Az.Storage.psd1
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,7 @@ RequiredAssemblies = 'Microsoft.Azure.Management.Storage.dll',
'Microsoft.Azure.DocumentDB.Core.dll', 'Microsoft.OData.Core.dll',
'Microsoft.OData.Edm.dll', 'Microsoft.Spatial.dll',
'Microsoft.Azure.KeyVault.Core.dll','Azure.Storage.Blobs.dll',
'Azure.Storage.Common.dll', 'Azure.Storage.Files.DataLake.dll',
'Azure.Core.dll', 'Microsoft.Bcl.AsyncInterfaces.dll',
'System.Text.Json.dll', 'System.Threading.Tasks.Extensions.dll'
'Azure.Storage.Common.dll', 'Azure.Storage.Files.DataLake.dll'

# Script files (.ps1) that are run in the caller's environment prior to importing this module.
# ScriptsToProcess = @()
Expand Down
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
18 changes: 18 additions & 0 deletions tools/CheckAssemblies.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,22 @@
# limitations under the License.
# ----------------------------------------------------------------------------------


function Get-PreloadAssemblies{
param(
[Parameter(Mandatory=$True)]
[string] $ModuleFolder
)

$preloadAssemblies = @()
$preloadFolderName = $PSEdition -eq 'Core' ? "NetCoreAssemblies" : "PreloadAssemblies"
$preloadFolder = [System.IO.Path]::Combine($ModuleFolder, $preloadFolderName)
if(Test-Path $preloadFolder){
$preloadAssemblies = (Get-ChildItem $preloadFolder -Filter "*.dll").Name | ForEach-Object { $_ -replace ".dll", ""}
}
$preloadAssemblies
}

param(
[ValidateNotNullOrEmpty()]
[ValidateSet('Debug', 'Release')]
Expand Down Expand Up @@ -38,6 +54,7 @@ foreach ($ModuleManifest in $ModuleManifestFiles) {
$LoadedAssemblies += $ModuleMetadata.RequiredAssemblies
}

$LoadedAssemblies += Get-PreloadAssemblies $ModuleManifest.Directory
$LoadedAssemblies += $ModuleMetadata.NestedModules

if ($ModuleMetadata.RequiredModules) {
Expand All @@ -58,6 +75,7 @@ foreach ($ModuleManifest in $ModuleManifestFiles) {
}
$LoadedAssemblies += $ModuleMetadata.NestedModules
}
$LoadedAssemblies += Get-PreloadAssemblies $RequiredModuleManifest.Directory
}
}

Expand Down