Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #899

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Fix typos #899

merged 1 commit into from
Jan 18, 2024

Conversation

shuoer86
Copy link
Contributor

No description provided.

@paritytech-cicd-pr
Copy link

BENCHMARKS

NATIVEWASMTIME
BENCHMARKMASTERPRDIFFMASTERPRDIFFWASMTIME OVERHEAD
execute/
br_table
1.58ms 1.71ms 🔴 7.93% 1.28ms 1.29ms ⚪ 0.99% 🟢 -25%
execute/
call/host/1
50.72µs 50.55µs ⚪ -0.34% 57.73µs 57.43µs ⚪ -0.51% 🟢 14%
execute/
call/rec
174.28µs 172.85µs ⚪ -0.82% 294.02µs 287.78µs ⚪ -2.12% 🟡 66%
execute/
count_until
5.42ms 5.42ms ⚪ 0.00% 7.29ms 7.31ms ⚪ 0.21% 🟢 35%
execute/
divrem
6.17ms 6.17ms ⚪ 0.00% 6.30ms 6.31ms ⚪ 0.12% 🟢 2%
execute/
factorial/iter
231.25µs 222.49µs 🟢 -3.79% 278.21µs 272.95µs 🟢 -1.89% 🟢 23%
execute/
factorial/rec
681.72µs 687.94µs ⚪ 0.91% 1.08ms 1.07ms ⚪ -0.88% 🟡 55%
execute/
fibonacci/iter
1.33ms 1.33ms ⚪ 0.40% 1.15ms 1.15ms ⚪ -0.14% 🟢 -14%
execute/
fibonacci/rec
5.96ms 6.07ms 🔴 1.76% 10.75ms 11.00ms 🔴 2.33% 🟡 81%
execute/
fibonacci/tail
1.21ms 1.22ms ⚪ 0.54% 4.27ms 4.30ms ⚪ 0.86% 🔴 254%
execute/
fuse
7.04ms 7.04ms ⚪ 0.00% 11.21ms 11.23ms ⚪ 0.12% 🟡 59%
execute/
global/bump
1.34ms 1.32ms ⚪ -1.40% 1.42ms 1.42ms ⚪ 0.18% 🟢 8%
execute/
global/get_const
484.15µs 481.60µs ⚪ -0.53% 729.14µs 730.14µs ⚪ 0.14% 🟡 52%
execute/
is_even/rec
1.12ms 1.13ms ⚪ 1.07% 1.84ms 1.84ms ⚪ -0.03% 🟡 63%
execute/
memory/fill_bytes
1.00ms 1.00ms ⚪ -0.04% 1.20ms 1.20ms ⚪ 0.11% 🟢 20%
execute/
memory/sum_bytes
1.14ms 1.14ms ⚪ 0.24% 1.23ms 1.23ms ⚪ 0.10% 🟢 7%
execute/
memory/vec_add
2.95ms 2.94ms ⚪ -0.02% 3.53ms 3.53ms ⚪ -0.02% 🟢 20%
execute/
recursive_scan
194.45µs 192.88µs ⚪ -0.81% 313.78µs 311.89µs ⚪ -0.60% 🟡 62%
execute/
recursive_trap
16.19µs 16.56µs 🔴 2.28% 27.20µs 27.27µs ⚪ 0.27% 🟡 65%
execute/
regex_redux
605.19µs 604.78µs ⚪ -0.07% 1.04ms 1.06ms 🔴 1.35% 🟡 75%
execute/
rev_complement
444.58µs 443.64µs ⚪ -0.21% 613.85µs 610.82µs ⚪ -0.49% 🟢 38%
execute/
tiny_keccak
348.53µs 347.95µs ⚪ -0.17% 336.06µs 338.05µs ⚪ 0.59% 🟢 -3%
execute/
trunc_f2i
633.51µs 634.03µs ⚪ 0.08% 939.19µs 939.75µs ⚪ 0.06% 🟢 48%
instantiate/
wasm_kernel
54.11µs 53.17µs ⚪ -1.74% 57.72µs 55.85µs 🟢 -3.24% 🟢 5%
overhead/
call/typed/0
1.24ms 1.28ms 🔴 3.07% 919.65µs 901.28µs 🟢 -2.00% 🟢 -30%
overhead/
call/typed/16
1.92ms 1.63ms 🟢 -14.76% 2.52ms 2.42ms 🟢 -4.00% 🟢 48%
overhead/
call/untyped/0
1.58ms 1.58ms ⚪ -0.26% 1.15ms 1.15ms ⚪ -0.44% 🟢 -27%
overhead/
call/untyped/16
2.41ms 2.41ms ⚪ -0.05% 4.26ms 4.20ms 🟢 -1.51% 🟡 74%
translate/
bz2/checked/eager/default
1.34ms 1.35ms ⚪ 0.55% 2.43ms 2.42ms ⚪ -0.57% 🟡 79%
translate/
bz2/checked/eager/fuel
1.45ms 1.45ms ⚪ 0.42% 2.64ms 2.63ms ⚪ -0.41% 🟡 81%
translate/
bz2/checked/lazy-translation/default
538.36µs 540.44µs ⚪ 0.38% 954.51µs 960.77µs ⚪ 0.66% 🟡 78%
translate/
bz2/checked/lazy/default
36.74µs 37.49µs 🔴 2.02% 46.55µs 45.51µs 🟢 -2.24% 🟢 21%
translate/
bz2/unchecked/eager/default
1.10ms 1.10ms ⚪ -0.03% 1.88ms 1.89ms ⚪ 0.25% 🟡 71%
translate/
erc1155/checked/eager/default
285.41µs 286.58µs ⚪ 0.41% 484.45µs 478.82µs ⚪ -1.16% 🟡 67%
translate/
erc1155/checked/eager/fuel
305.22µs 308.84µs ⚪ 1.19% 514.43µs 512.41µs ⚪ -0.39% 🟡 66%
translate/
erc1155/checked/lazy-translation/default
127.21µs 127.79µs ⚪ 0.46% 211.37µs 211.91µs ⚪ 0.26% 🟡 66%
translate/
erc1155/checked/lazy/default
26.19µs 26.33µs ⚪ 0.53% 32.90µs 32.11µs 🟢 -2.41% 🟢 22%
translate/
erc1155/unchecked/eager/default
233.30µs 234.34µs ⚪ 0.44% 374.76µs 376.29µs ⚪ 0.41% 🟡 61%
translate/
erc20/checked/eager/default
139.26µs 141.07µs 🔴 1.30% 232.79µs 245.88µs 🔴 5.62% 🟡 74%
translate/
erc20/checked/eager/fuel
146.69µs 149.59µs 🔴 1.98% 244.65µs 242.04µs ⚪ -1.07% 🟡 62%
translate/
erc20/checked/lazy-translation/default
65.13µs 66.11µs 🔴 1.52% 106.68µs 116.83µs 🔴 9.52% 🟡 77%
translate/
erc20/checked/lazy/default
19.04µs 19.37µs 🔴 1.72% 24.81µs 24.69µs ⚪ -0.49% 🟢 27%
translate/
erc20/unchecked/eager/default
113.89µs 114.13µs ⚪ 0.21% 179.48µs 178.42µs ⚪ -0.59% 🟡 56%
translate/
erc721/checked/eager/default
196.92µs 199.37µs ⚪ 1.24% 336.59µs 330.28µs 🟢 -1.87% 🟡 66%
translate/
erc721/checked/eager/fuel
207.34µs 209.54µs ⚪ 1.06% 353.50µs 349.06µs ⚪ -1.26% 🟡 67%
translate/
erc721/checked/lazy-translation/default
91.63µs 92.01µs ⚪ 0.42% 151.97µs 150.58µs ⚪ -0.92% 🟡 64%
translate/
erc721/checked/lazy/default
23.38µs 23.70µs ⚪ 1.40% 29.19µs 28.91µs ⚪ -0.94% 🟢 22%
translate/
erc721/unchecked/eager/default
159.54µs 159.17µs ⚪ -0.23% 255.97µs 253.92µs ⚪ -0.80% 🟡 60%
translate/
pulldown_cmark/checked/eager/default
3.64ms 3.63ms ⚪ -0.46% 6.20ms 6.18ms ⚪ -0.33% 🟡 70%
translate/
pulldown_cmark/checked/eager/fuel
3.93ms 3.95ms ⚪ 0.37% 6.70ms 6.67ms ⚪ -0.44% 🟡 69%
translate/
pulldown_cmark/checked/lazy-translation/default
1.52ms 1.53ms ⚪ 0.41% 2.55ms 2.55ms ⚪ 0.13% 🟡 67%
translate/
pulldown_cmark/checked/lazy/default
254.71µs 251.16µs ⚪ -1.39% 253.38µs 251.68µs ⚪ -0.67% 🟢 0%
translate/
pulldown_cmark/unchecked/eager/default
3.06ms 3.07ms ⚪ 0.48% 4.93ms 4.92ms ⚪ -0.33% 🟡 60%
translate/
spidermonkey/checked/eager/default
76.88ms 76.81ms ⚪ -0.09% 136.44ms 134.21ms ⚪ -1.63% 🟡 75%
translate/
spidermonkey/checked/eager/fuel
83.04ms 83.33ms ⚪ 0.34% 145.64ms 145.37ms ⚪ -0.19% 🟡 74%
translate/
spidermonkey/checked/lazy-translation/default
31.77ms 31.72ms ⚪ -0.16% 55.45ms 55.46ms ⚪ 0.02% 🟡 75%
translate/
spidermonkey/checked/lazy/default
3.24ms 3.24ms ⚪ 0.15% 3.88ms 3.80ms 🟢 -1.92% 🟢 17%
translate/
spidermonkey/unchecked/eager/default
63.86ms 63.73ms ⚪ -0.21% 105.49ms 105.29ms ⚪ -0.18% 🟡 65%
translate/
wasm_kernel/checked/eager/default
5.11ms 5.14ms ⚪ 0.52% 8.86ms 8.73ms 🟢 -1.40% 🟡 70%
translate/
wasm_kernel/checked/eager/fuel
5.27ms 5.28ms ⚪ 0.28% 9.29ms 9.22ms ⚪ -0.82% 🟡 74%
translate/
wasm_kernel/checked/lazy-translation/default
2.39ms 2.41ms ⚪ 0.46% 3.99ms 3.96ms ⚪ -0.78% 🟡 65%
translate/
wasm_kernel/checked/lazy/default
421.68µs 428.21µs ⚪ 1.55% 496.09µs 500.29µs ⚪ 0.85% 🟢 17%
translate/
wasm_kernel/unchecked/eager/default
4.16ms 4.14ms ⚪ -0.47% 6.81ms 6.79ms ⚪ -0.39% 🟡 64%

Link to pipeline

@Robbepop
Copy link
Member

@shuoer86 thank you for the typo fixes!

The clippy CI job fails due to this Clippy bug which apparently seems to not have been release, yet:
rust-lang/rust-clippy#12133

@Robbepop Robbepop merged commit 59f9acc into wasmi-labs:master Jan 18, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants