Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Trap type #650

Merged
merged 1 commit into from
Feb 4, 2023
Merged

Refactor Trap type #650

merged 1 commit into from
Feb 4, 2023

Conversation

Robbepop
Copy link
Member

@Robbepop Robbepop commented Feb 4, 2023

  • Trap no longer is Clone
  • Added Trap::{downcast_mut, downcast} methods

- Trap no longer is Clone
- Added Trap::{downcast_mut, downcast} methods
@paritytech-cicd-pr
Copy link

BENCHMARKS

NATIVEWASMTIME
BENCHMARKMASTERPRDIFFMASTERPRDIFFWASMTIME OVERHEAD
execute/
bare_call_0
1.47ms 1.39ms 🟢 -5.34% 1.16ms 1.17ms 🟢 1.03% 🟢 -16%
execute/
bare_call_0/typed
1.03ms 1.02ms ⚪ -0.79% 803.85µs 760.45µs 🟢 -5.30% 🟢 -25%
execute/
bare_call_1
1.51ms 1.43ms 🟢 -5.50% 1.40ms 1.36ms 🔴 -2.54% 🟢 -4%
execute/
bare_call_16
2.44ms 2.26ms 🟢 -7.29% 4.16ms 4.34ms 🔴 4.36% 🟡 92%
execute/
bare_call_16/typed
1.94ms 1.56ms 🟢 -19.44% 2.74ms 2.28ms 🟢 -16.82% 🟢 47%
execute/
bare_call_1/typed
1.18ms 1.11ms 🟢 -5.33% 1.17ms 1.18ms 🔴 1.32% 🟢 6%
execute/
bare_call_4
1.64ms 1.56ms 🟢 -3.96% 2.08ms 2.04ms 🟢 -1.89% 🟢 31%
execute/
bare_call_4/typed
1.16ms 1.14ms 🟢 -1.95% 1.34ms 1.25ms 🟢 -6.68% 🟢 10%
execute/
br_table
1.23ms 1.13ms 🟢 -6.51% 1.41ms 1.45ms 🔴 3.43% 🟢 29%
execute/
count_until
651.79µs 682.29µs 🔴 4.59% 2.29ms 2.16ms 🟢 -5.48% 🔴 217%
execute/
factorial_iterative
328.77µs 327.78µs ⚪ -0.21% 957.47µs 916.67µs 🟢 -4.39% 🔴 180%
execute/
factorial_recursive
656.72µs 645.93µs 🟢 -1.75% 1.40ms 1.35ms 🟢 -3.47% 🔴 109%
execute/
fib_iterative
1.36ms 1.36ms ⚪ -0.01% 4.99ms 5.01ms ⚪ 0.31% 🔴 269%
execute/
fib_recursive
5.92ms 6.08ms 🔴 2.64% 12.50ms 11.99ms 🟢 -4.03% 🟡 97%
execute/
global_bump
977.05µs 960.54µs 🟢 -1.72% 2.63ms 2.79ms 🔴 5.93% 🔴 190%
execute/
global_const
745.55µs 737.22µs ⚪ -1.76% 2.44ms 2.40ms 🟢 -1.68% 🔴 226%
execute/
host_calls
26.51µs 26.21µs 🟢 -1.18% 40.37µs 39.17µs 🟢 -2.99% 🟢 49%
execute/
memory_fill
1.21ms 1.26ms 🔴 3.38% 4.17ms 4.04ms 🟢 -3.52% 🔴 221%
execute/
memory_sum
1.18ms 1.22ms 🔴 3.05% 4.16ms 4.02ms 🟢 -3.19% 🔴 230%
execute/
memory_vec_add
2.48ms 2.50ms ⚪ 0.81% 7.83ms 7.65ms 🟢 -2.27% 🔴 206%
execute/
recursive_is_even
1.14ms 1.13ms ⚪ -0.35% 2.36ms 2.19ms 🟢 -7.09% 🟡 93%
execute/
recursive_ok
161.44µs 153.34µs 🟢 -4.98% 326.32µs 312.36µs 🟢 -4.22% 🔴 104%
execute/
recursive_scan
182.90µs 183.21µs ⚪ 0.28% 407.81µs 395.13µs 🟢 -3.19% 🔴 116%
execute/
recursive_trap
16.79µs 15.75µs 🟢 -6.82% 32.67µs 31.18µs 🟢 -4.32% 🟡 98%
execute/
regex_redux
569.49µs 533.86µs 🟢 -6.22% 1.43ms 1.37ms 🟢 -3.83% 🔴 157%
execute/
rev_complement
480.89µs 480.34µs ⚪ -0.07% 1.44ms 1.40ms 🟢 -2.71% 🔴 191%
execute/
tiny_keccak
341.38µs 334.04µs 🟢 -2.19% 1.15ms 1.15ms ⚪ -0.07% 🔴 243%
execute/
trunc_f2i
708.17µs 722.95µs 🔴 2.10% 2.19ms 2.14ms 🟢 -1.84% 🔴 196%
instantiate/
wasm_kernel
64.27µs 64.07µs ⚪ 0.04% 68.84µs 69.58µs 🔴 1.96% 🟢 9%
translate/
erc1155
210.26µs 209.58µs ⚪ -0.38% 387.34µs 389.15µs ⚪ 0.56% 🟡 86%
translate/
erc20
106.10µs 103.41µs 🟢 -3.73% 190.19µs 192.90µs ⚪ 1.22% 🟡 87%
translate/
erc721
148.91µs 147.39µs ⚪ -0.99% 275.86µs 277.75µs ⚪ 0.90% 🟡 88%
translate/
spidermonkey
0.00ns 0.00ns ⚪ -0.30% 0.00ns 0.00ns 🔴 1.80% 🟢 0%
translate/
wasm_kernel
3.93ms 3.92ms ⚪ -0.35% 7.23ms 7.30ms ⚪ 0.42% 🟡 86%

Link to pipeline

@Robbepop Robbepop merged commit 0666aa8 into master Feb 4, 2023
@Robbepop Robbepop deleted the rf-better-trap branch February 4, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants