Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and cleanup traits underlying to IntoFunc #620

Merged
merged 6 commits into from
Jan 19, 2023
Merged

Conversation

Robbepop
Copy link
Member

No description provided.

As done in Wasmtime. This allows us to more easily change those traits in the future and avoids users to rely on them.
This is a short term solution until we get to rework the underlying traits to make them more similar to the Wasmtime traits.
@paritytech-cicd-pr
Copy link

BENCHMARKS

NATIVEWASMTIME
BENCHMARKMASTERPRDIFFMASTERPRDIFFWASMTIME OVERHEAD
execute/
bare_call_0
1.41ms 1.41ms ⚪ 0.02% 1.16ms 1.16ms ⚪ 0.50% 🟢 -18%
execute/
bare_call_0/typed
1.01ms 1.01ms ⚪ 0.00% 725.88µs 723.48µs ⚪ -0.09% 🟢 -28%
execute/
bare_call_1
1.46ms 1.46ms ⚪ 0.19% 1.40ms 1.45ms 🔴 3.27% 🟢 -1%
execute/
bare_call_16
2.47ms 2.49ms ⚪ 1.00% 4.22ms 4.19ms ⚪ -0.54% 🟡 68%
execute/
bare_call_16/typed
1.58ms 1.58ms ⚪ -0.03% 2.47ms 2.46ms ⚪ -0.26% 🟡 56%
execute/
bare_call_1/typed
1.10ms 1.10ms ⚪ 0.06% 1.10ms 1.13ms 🔴 3.09% 🟢 3%
execute/
bare_call_4
1.63ms 1.63ms ⚪ -0.50% 1.96ms 2.00ms 🔴 1.85% 🟢 23%
execute/
bare_call_4/typed
1.12ms 1.11ms ⚪ -0.33% 1.13ms 1.11ms 🟢 -1.43% 🟢 -0%
execute/
br_table
1.11ms 1.11ms ⚪ -0.82% 1.27ms 1.26ms ⚪ -0.20% 🟢 14%
execute/
count_until
681.37µs 681.56µs ⚪ 0.05% 2.12ms 2.12ms ⚪ -0.26% 🔴 211%
execute/
factorial_iterative
327.79µs 336.92µs 🔴 2.68% 882.07µs 882.20µs ⚪ -0.05% 🔴 162%
execute/
factorial_recursive
690.91µs 640.29µs 🟢 -7.34% 1.39ms 1.40ms ⚪ 0.64% 🔴 119%
execute/
fib_iterative
1.43ms 1.43ms ⚪ 0.05% 4.65ms 4.63ms ⚪ -0.67% 🔴 223%
execute/
fib_recursive
5.68ms 5.70ms ⚪ 0.34% 12.50ms 12.42ms ⚪ -0.91% 🔴 118%
execute/
global_bump
993.76µs 993.92µs ⚪ -0.01% 3.30ms 3.29ms ⚪ 0.01% 🔴 231%
execute/
global_const
717.20µs 716.93µs ⚪ -0.04% 2.40ms 2.40ms ⚪ 0.00% 🔴 234%
execute/
host_calls
29.19µs 29.15µs ⚪ -0.26% 41.25µs 46.37µs 🔴 12.70% 🟡 59%
execute/
memory_fill
1.24ms 1.24ms ⚪ 0.02% 3.87ms 3.87ms ⚪ 0.13% 🔴 213%
execute/
memory_sum
1.22ms 1.22ms ⚪ 0.01% 3.89ms 3.89ms ⚪ -0.05% 🔴 219%
execute/
memory_vec_add
2.54ms 2.59ms 🔴 1.98% 8.00ms 8.10ms ⚪ 1.19% 🔴 213%
execute/
recursive_is_even
1.19ms 1.19ms ⚪ 0.40% 2.26ms 2.26ms ⚪ 0.01% 🟡 90%
execute/
recursive_ok
155.32µs 153.62µs ⚪ -1.16% 323.46µs 326.91µs ⚪ 0.88% 🔴 113%
execute/
recursive_scan
178.18µs 178.53µs ⚪ 0.13% 417.49µs 417.58µs ⚪ 0.10% 🔴 134%
execute/
recursive_trap
14.42µs 14.39µs ⚪ -0.18% 32.73µs 32.75µs ⚪ 0.13% 🔴 128%
execute/
regex_redux
547.52µs 536.06µs 🟢 -2.27% 1.50ms 1.49ms ⚪ -0.40% 🔴 179%
execute/
rev_complement
485.45µs 481.32µs ⚪ -1.06% 1.43ms 1.44ms ⚪ 0.79% 🔴 200%
execute/
tiny_keccak
367.57µs 365.91µs ⚪ -0.50% 1.19ms 1.19ms ⚪ 0.25% 🔴 225%
execute/
trunc_f2i
906.91µs 905.73µs ⚪ -0.12% 2.46ms 2.48ms ⚪ 0.57% 🔴 174%
instantiate/
wasm_kernel
67.24µs 64.97µs 🟢 -4.14% 84.85µs 85.41µs ⚪ 0.82% 🟢 31%
translate/
erc1155
205.72µs 206.43µs ⚪ 0.36% 420.38µs 417.89µs ⚪ -0.33% 🔴 102%
translate/
erc20
101.26µs 101.42µs ⚪ 0.17% 204.09µs 208.93µs 🔴 4.20% 🔴 106%
translate/
erc721
145.88µs 145.66µs ⚪ -0.12% 299.12µs 298.00µs ⚪ -0.25% 🔴 105%
translate/
spidermonkey
0.00ns 0.00ns ⚪ -0.04% 0.00ns 0.00ns 🔴 2.41% 🟢 0%
translate/
wasm_kernel
3.80ms 3.81ms ⚪ 0.20% 8.04ms 8.13ms 🔴 3.17% 🔴 114%

Link to pipeline

@Robbepop Robbepop merged commit 591c767 into master Jan 19, 2023
@Robbepop Robbepop deleted the rf-traits-docs branch January 19, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants