Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an experiment to see whether the move overhead of storing reusable allocations by value outweights the indirection overhead of accessing them via reference. Locally I see no significant change in performance, however, so far it seems that the access via reference is by far simpler to setup and use and produces slightly more readable code imo.
These changes might also make it simpler to implement parallel parsing, validation and translation in future versions of
wasmi
. That means that all functions are parsed, validated and translated in parallel isolation. So farwasmi
does not support parallel translation of functions sincewasmi
is primarily used by us as Wasm binary and Wasm does not (yet) support parallelism.