Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support allocating 4GB of memory #452

Merged
merged 4 commits into from
Sep 20, 2022
Merged

Support allocating 4GB of memory #452

merged 4 commits into from
Sep 20, 2022

Conversation

bkchr
Copy link

@bkchr bkchr commented Sep 19, 2022

No description provided.

@bkchr bkchr requested review from pepyakin and Robbepop September 19, 2022 14:32
Robbepop
Robbepop reviewed Sep 19, 2022
View reviewed changes
Robbepop
Robbepop reviewed Sep 19, 2022
View reviewed changes
Robbepop
Robbepop approved these changes Sep 19, 2022
View reviewed changes
Copy link
Member

@Robbepop Robbepop left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The question now is how we are going to publish this updated legacy wasmi version.
If we want to stay semver compatible we should actually publish it under a new name.
In the past we thought that wasmi-legacy was probably the best name for that.

bkchr
bkchr commented Sep 20, 2022
View reviewed changes
@bkchr bkchr merged commit 4e85c57 into wasmi-v0.13.x-release Sep 20, 2022
@bkchr bkchr deleted the wasmi-v0.13.1 branch September 20, 2022 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Robbepop Robbepop Robbepop approved these changes

@pepyakin pepyakin Awaiting requested review from pepyakin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bkchr @Robbepop